[jira] [Commented] (BUILDR-673) MultiTest options are broken

["John Roth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735680#comment-13735680 ] 

John Roth commented on BUILDR-673:
----------------------------------

Actually, it does not pass the value of the ":options" option to MultiTest, but rather the entire MultiTest option hash. Which is even worse. 
                
> MultiTest options are broken
> ----------------------------
>
>                 Key: BUILDR-673
>                 URL: https://issues.apache.org/jira/browse/BUILDR-673
>             Project: Buildr
>          Issue Type: Bug
>          Components: Test frameworks
>    Affects Versions: 1.4.11, 1.4.12
>         Environment: All
>            Reporter: John Roth
>
> Documentation indicates that the ":options" to MultiTest is a hash with keys like ":junit" or ":testng" and values a hash of options to be passed to that test framework. But, in fact, the entire ":options" hash is passed to each framework. 
> In particular, tests.rb line 392 (see context below) reads "f.new(task,options)" but should read "f.new(task, framework_options)" ("framework_options" is otherwise an unread variable in tests.rb.)
>     def initialize(task, options) #:nodoc:
>       super
>       fail "Missing :frameworks option" unless options[:frameworks]
>       @frameworks = options[:frameworks].map do |f|
>         framework_options = (options[:options] || {})[f.to_sym] || {}
>         f.new(task, options)
>       end
>     end

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira