[GitHub] [sling-org-apache-sling-feature-launcher] kwin commented on a diff in pull request #39: SLING-11408 Use runtime scope for packaging application

[GitBox <gi...@apache.org>]

kwin commented on code in PR #39:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/39#discussion_r904780378


##########
pom.xml:
##########
@@ -198,24 +234,24 @@
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-text</artifactId>
             <version>1.9</version>
-            <scope>provided</scope>
+            <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-lang3</artifactId>
             <version>3.12.0</version>
-            <scope>provided</scope>
+            <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>org.osgi</groupId>

Review Comment:
   Replacing `osgi.core` by the individual spec chapter dependencies is hard, as most dependencies transitively just declare a dependency on `osgi.core` and not the individual spec chapters, therefore I would tend to leave it like that although most probably not all packages/spec chapters are really necessary here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org