You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/18 16:38:50 UTC

[GitHub] [hudi] manojpec commented on a change in pull request #4372: [HUDI-3064] Fixing a bug in FileSystemTestLock and TransactionManager resetting txn details

manojpec commented on a change in pull request #4372:
URL: https://github.com/apache/hudi/pull/4372#discussion_r771842651



##########
File path: hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/FileSystemBasedLockProviderTestClass.java
##########
@@ -76,7 +76,7 @@ public boolean tryLock(long time, TimeUnit unit) {
     try {
       int numRetries = 0;
       while (fs.exists(new Path(lockPath + "/" + LOCK_NAME))
-          && (numRetries <= lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_NUM_RETRIES_PROP_KEY))) {
+          && (numRetries++ <= lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_NUM_RETRIES_PROP_KEY))) {

Review comment:
       This will non fix the test flakiness. Test assumes a different exception to be raised. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org