You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "arend-von-reinersdorff (via GitHub)" <gi...@apache.org> on 2025/01/31 16:24:54 UTC
[PR] Add example of profile activation with value true [maven-site]
arend-von-reinersdorff opened a new pull request, #659:
URL: https://github.com/apache/maven-site/pull/659
I was looking for an example like this recently. And I was surprised that there's an example for profile activation with property value false but not example of profile activation with property value true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add example of profile activation with value true [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #659:
URL: https://github.com/apache/maven-site/pull/659#discussion_r1938238904
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -260,6 +260,30 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
</profiles>
+---+
+ The following profile will be activated when the system property "debug" is defined with no value,
+ or is defined with the value "true".
+
++---+
+<profiles>
+ <profile>
+ <activation>
+ <property>
+ <name>debug</name>
+ <value>true</value>
+ </property>
+ </activation>
Review Comment:
Ok, but it is not a feature o profile but feature how user properties are initialized by CLI
By the way we need check if it documented somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add example of profile activation with value true [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #659:
URL: https://github.com/apache/maven-site/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add example of profile activation with value true [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #659:
URL: https://github.com/apache/maven-site/pull/659#discussion_r1937583788
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -260,6 +260,30 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
</profiles>
+---+
+ The following profile will be activated when the system property "debug" is defined with no value,
+ or is defined with the value "true".
+
++---+
+<profiles>
+ <profile>
+ <activation>
+ <property>
+ <name>debug</name>
+ <value>true</value>
+ </property>
+ </activation>
Review Comment:
We have already example like:
```
<activation>
<property>
<name>environment</name>
<value>test</value>
</property>
</activation>
```
is it not the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add example of profile activation with value true [maven-site]
Posted by "arend-von-reinersdorff (via GitHub)" <gi...@apache.org>.
arend-von-reinersdorff commented on code in PR #659:
URL: https://github.com/apache/maven-site/pull/659#discussion_r1937969369
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -260,6 +260,30 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
</profiles>
+---+
+ The following profile will be activated when the system property "debug" is defined with no value,
+ or is defined with the value "true".
+
++---+
+<profiles>
+ <profile>
+ <activation>
+ <property>
+ <name>debug</name>
+ <value>true</value>
+ </property>
+ </activation>
Review Comment:
value=true is a special case which allows to set the property on the command line without a value like this:
mvn groupId:artifactId:goal -Ddebug
Other values require a value to be specified on the command line like this:
mvn groupId:artifactId:goal -Ddebug=test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org