[GitHub] [beam] Dippatel98 commented on a diff in pull request #27020: Adding error tags in BigQuery Write Transforms

["Dippatel98 (via GitHub)" <gi...@apache.org>]

Dippatel98 commented on code in PR #27020:
URL: https://github.com/apache/beam/pull/27020#discussion_r1219719931


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java:
##########
@@ -114,7 +114,7 @@ public List<String> inputCollectionNames() {
 
   @Override
   public List<String> outputCollectionNames() {
-    return Arrays.asList(FAILED_ROWS_TAG, FAILED_ROWS_WITH_ERRORS_TAG);
+    return Arrays.asList(FAILED_ROWS_TAG, FAILED_ROWS_WITH_ERRORS_TAG, "errors");

Review Comment:
   I am not sure about that. I did not want to break backwards compatibility so I just added an error tag instead of replacing the existing tags. Maybe @johnjcasey knows if anyone is using those tags. Still I think the safer approach is adding instead of replacing ( Hyrum's Law :) ). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org