You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/01/21 23:30:06 UTC
[GitHub] [incubator-daffodil] mbeckerle opened a new pull request #477: Removed test looking for compile time check.
mbeckerle opened a new pull request #477:
URL: https://github.com/apache/incubator-daffodil/pull/477
A run time check for negative indexes is sufficient.
DAFFODIL-1865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle merged pull request #477: Removed test looking for compile time check.
Posted by GitBox <gi...@apache.org>.
mbeckerle merged pull request #477:
URL: https://github.com/apache/incubator-daffodil/pull/477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #477: Removed test looking for compile time check.
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #477:
URL: https://github.com/apache/incubator-daffodil/pull/477#issuecomment-765385063
Looks like there was a test failure unrelated to the change.I've created ticket [DAFFODIL-2461](https://issues.apache.org/jira/browse/DAFFODIL-2461) to investigate that.
Looks fine otherwise, +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #477: Removed test looking for compile time check.
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #477:
URL: https://github.com/apache/incubator-daffodil/pull/477#issuecomment-765410234
Ill take a look at that failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org