You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2026/08/12 18:54:27 UTC
[PR] fix(table): repair task residual CI failures [iceberg-go]
zeroshade opened a new pull request, #1790:
URL: https://github.com/apache/iceberg-go/pull/1790
## Summary
- move the task-residual integration assertion into `TestReadTasks`, where its table, allocator, schema, and reference fixtures are defined
- only bind task residuals when they are present, avoiding the overwritten assignment reported by staticcheck
- apply `gofumpt` formatting required by CI
## Testing
- `go test -tags=integration -run "^$" ./table`
- `go test ./table`
- `golangci-lint run --timeout=10m ./table/...`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): repair task residual CI failures [iceberg-go]
Posted by "badalprasadsingh (via GitHub)" <gi...@apache.org>.
badalprasadsingh commented on PR #1790:
URL: https://github.com/apache/iceberg-go/pull/1790#issuecomment-5271414742
I’ve opened a PR #1789 addressing both lint failures from the hotfix. Would appreciate your review if you have time 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): repair task residual CI failures [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed pull request #1790: fix(table): repair task residual CI failures
URL: https://github.com/apache/iceberg-go/pull/1790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): repair task residual CI failures [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #1790:
URL: https://github.com/apache/iceberg-go/pull/1790#issuecomment-5271517887
Superseded by #1789, which fixes the same #1676 fallout and merged first. Thanks @badalprasadsingh for the quick hotfix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): repair task residual CI failures [iceberg-go]
Posted by "badalprasadsingh (via GitHub)" <gi...@apache.org>.
badalprasadsingh commented on PR #1790:
URL: https://github.com/apache/iceberg-go/pull/1790#issuecomment-5271592345
anytime! @zeroshade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): repair task residual CI failures [iceberg-go]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1790:
URL: https://github.com/apache/iceberg-go/pull/1790#discussion_r3769442333
##########
table/scanner_test.go:
##########
@@ -431,6 +398,40 @@ func (s *ScannerSuite) TestReadTasks() {
s.Require().False(valid)
})
}
+
+ s.Run("task residual", func() {
+ ctx := compute.WithAllocator(s.ctx, mem)
+ scan := tbl.Scan(table.WithRowFilter(iceberg.AlwaysTrue{}),
+ table.WithSelectedFields("number"))
+ tasks, err := scan.PlanFiles(ctx)
Review Comment:
This new subtest doesn’t use a `memory.NewCheckedAllocatorScope(mem)` like the other `TestReadTasks` subtests, which makes it harder to localize Arrow allocator leaks to this case (leaks would only show up at the end of the parent test via `mem.AssertSize`). Consider adding the same scoped allocator check here for consistency and faster leak diagnosis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org