You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2025/03/06 09:34:42 UTC
[PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
NihalJain opened a new pull request, #6759:
URL: https://github.com/apache/hbase/pull/6759
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703340583
I'm sorry I asked. Frontend tooling is out of hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703329831
I wonder if there's a maven plugin that we could use to resolve these JS file dependencies at build time and with CRC verification...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2704009825
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 12s | | master passed |
| +1 :green_heart: | javadoc | 2m 24s | | master passed |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 0s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 23s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 269m 37s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) | root in the patch failed. |
| | | 287m 19s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6759 |
| Optional Tests | javac javadoc unit |
| uname | Linux bfa307a88cfb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ce22878949c92176001e5e25fccbddbc21b9225f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/testReport/ |
| Max. process+thread count | 6031 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain merged PR #6759:
URL: https://github.com/apache/hbase/pull/6759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703343340
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | jshint | 0m 0s | | jshint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 8s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 59s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | | The patch does not generate ASF License warnings. |
| | | 10m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6759 |
| Optional Tests | dupname asflicense javac codespell detsecrets spotless jshint |
| uname | Linux 8cb304908904 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ce22878949c92176001e5e25fccbddbc21b9225f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-server . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6759/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "PDavid (via GitHub)" <gi...@apache.org>.
PDavid commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703410940
> > I wonder if there's a maven plugin that we could use to resolve these JS file dependencies at build time and with CRC verification...
>
> We could write a maven exec plugin / script to (optionally) ensure the js files are intact. Could run this as part of release?
>
> * Download the JS files from CDN and calculate their CRC.
> * Calculate the CRC of the local JS files.
> * Compare the CRC values.
>
> Or else we can look in direction of [issues.apache.org/jira/browse/HBASE-27802](https://issues.apache.org/jira/browse/HBASE-27802)
Another possibility would be to depend on webjars with the maven-dependency-plugin and extract them to proper place like what I did for the website and reference guide here:
https://github.com/apache/hbase/blob/master/pom.xml#L2766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703307517
Built HBase assembly tarball locally. Started HBase in hbase.cluster.distributed=false mode. Ran some ops. Opened Master web UI and verified the visualisations are as expected.
<img width="1312" alt="Screenshot 2025-03-06 at 2 57 14 PM" src="https://github.com/user-attachments/assets/ae15db2c-71d7-42fa-890a-92bf8d0233f0" />
NOTE: Above image is edited to hide IP with thick line
Also clicked on the various options available for the visualisation, like save SVG, PNG etc. and ensured all the 5 options work as expected.
Also verified http://localhost:16010/static/js/ has expected JS files:
<img width="577" alt="Screenshot 2025-03-06 at 2 55 02 PM" src="https://github.com/user-attachments/assets/ecf4cb4b-07a5-4bba-a562-b1ae17278b09" />
The attached JS files are downloaded from below CDN:
- https://cdn.jsdelivr.net/npm/vega@5.32.0
- https://cdn.jsdelivr.net/npm/vega-lite@5.23.0
- https://cdn.jsdelivr.net/npm/vega-embed@6.29.0
FYI @ndimiduk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703416406
> proper place like what I did for the website and reference guide here:
> > > I wonder if there's a maven plugin that we could use to resolve these JS file dependencies at build time and with CRC verification...
> >
> >
> > We could write a maven exec plugin / script to (optionally) ensure the js files are intact. Could run this as part of release?
> >
> > * Download the JS files from CDN and calculate their CRC.
> > * Calculate the CRC of the local JS files.
> > * Compare the CRC values.
> >
> > Or else we can look in direction of [issues.apache.org/jira/browse/HBASE-27802](https://issues.apache.org/jira/browse/HBASE-27802)
>
> Another possibility would be to depend on webjars with the maven-dependency-plugin and extract them to proper place like what I did for the website and reference guide here: https://github.com/apache/hbase/blob/master/pom.xml#L2766
Ah right, we can take this route, we need need depend on bower (which requires npm) this way. Sounds good to me. Feel free to take over [HBASE-27802](https://issues.apache.org/jira/browse/HBASE-27802)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2703376293
> I wonder if there's a maven plugin that we could use to resolve these JS file dependencies at build time and with CRC verification...
We could write a maven exec plugin and script to ensure the js files are intact.
- Download the JS files from CDN and calculate their CRC.
- Calculate the CRC of the local JS files.
- Compare the CRC values.
Or else we can look in direction of https://issues.apache.org/jira/browse/HBASE-27802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29167 Upgrade vega and its related js libraries [hbase]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6759:
URL: https://github.com/apache/hbase/pull/6759#issuecomment-2705596558
Failures are not related. Going ahead and merging. Will push to all active branches as this is a security fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org