[GitHub] [iceberg] aokolnychyi edited a comment on pull request #2255: API: Add v2 Actions API

[GitBox <gi...@apache.org>]

aokolnychyi edited a comment on pull request #2255:
URL: https://github.com/apache/iceberg/pull/2255#issuecomment-790067044


   I think the only open point on this PR is whether we have any better ideas around snapshot/migrate methods. I think implementations like `SparkActions` can offer methods that accept Spark `Catalog` and `Identifier`. That's what we are going to use in our procedures.
   
   We may consider either exposing such methods alongside the methods that accept strings or we can introduce type parameters in `ActionProvider`.
   
   ```
   public interface ActionsProvider<C, I> {
   
     default SnapshotTable snapshotTable(C sourceCatalog, I sourceIdent) {
       throw new UnsupportedOperationException(this.getClass().getName() + " does not implement snapshotTable");
     }
   
     default MigrateTable migrateTable(C catalog, I ident) {
       throw new UnsupportedOperationException(this.getClass().getName() + " does not implement migrateTable");
     }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org