[jira] [Commented] (HBASE-25706) Support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy

["Duo Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310190#comment-17310190 ] 

Duo Zhang commented on HBASE-25706:
-----------------------------------

I think this is a design problem.

Typically, there are two dimensions for split policy, one is whether we should split a region, the other is how to find a suitable split point. Of course the suitable split point is always the one which could split the region evenly, so maybe a more accurate description here is that, restrict the pattern of the split point.

Actually, for KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy, we are setting the special pattern of the split point, while ConstantSizeSplitPolicy and IncreasingToUpperBound policy, we are setting the rule on whether we should split a region.

So in general, I do not think KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy should be called as 'SplitPolicy'. They should be something like 'SplitPointRestriction'.

So maybe we could just deprecate these two split policies, and introduce a splitPointRestriction config for other split policies. It could be 'None', 'KeyPrefix', 'DelimitedKeyPrefix'. Of course we still need to find a way to pass configs to these 'restrictions', but I think this is a better abstraction here.

What do you think? [~brfrn169].

And ping [~stack].

Thanks.

> Support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-25706
>                 URL: https://issues.apache.org/jira/browse/HBASE-25706
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>
> Basically, I think we can use KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy along with other split policies. In this Jira, we will support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy to use them with different split policies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)