You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/09/08 18:59:57 UTC
[jira] Created: (WINK-172) Improve invalid media type toleration
Improve invalid media type toleration
-------------------------------------
Key: WINK-172
URL: https://issues.apache.org/jira/browse/WINK-172
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.2
Reporter: Bryant Luk
Assignee: Bryant Luk
Fix For: 0.2
Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
The two I think should be corrected:
"*" turn to MediaType.WILDCARD
"text/" (missing subtype) turn to "text/*" (or as appropriate)
The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-172) Improve invalid media type toleration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753276#action_12753276 ]
Hudson commented on WINK-172:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #140 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/140/])
Send a 400 when Accept header has invalid types
See []
> Improve invalid media type toleration
> -------------------------------------
>
> Key: WINK-172
> URL: https://issues.apache.org/jira/browse/WINK-172
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
> The two I think should be corrected:
> "*" turn to MediaType.WILDCARD
> "text/" (missing subtype) turn to "text/*" (or as appropriate)
> The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-172) Improve invalid media type toleration
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-172.
---------------------------
> Improve invalid media type toleration
> -------------------------------------
>
> Key: WINK-172
> URL: https://issues.apache.org/jira/browse/WINK-172
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
> The two I think should be corrected:
> "*" turn to MediaType.WILDCARD
> "text/" (missing subtype) turn to "text/*" (or as appropriate)
> The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-172) Improve invalid media type toleration
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752875#action_12752875 ]
Bryant Luk commented on WINK-172:
---------------------------------
I've gone ahead and changed the toleration for {code}"*"{code} to a {code}"*/*"{code} since some JDKs and other clients have an Accept header with "*" in it by default and there's no chance to change that code.
On some thought, for changing the "text/" to "text/*" or other invalid accept headers, the right response may be a 400 response instead of the current 500 (or skipping invalid media types). I'm leaning more towards the 400 instead of encouraging bad behavior.
> Improve invalid media type toleration
> -------------------------------------
>
> Key: WINK-172
> URL: https://issues.apache.org/jira/browse/WINK-172
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
> The two I think should be corrected:
> "*" turn to MediaType.WILDCARD
> "text/" (missing subtype) turn to "text/*" (or as appropriate)
> The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-172) Improve invalid media type toleration
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-172.
-----------------------------
Resolution: Fixed
Throws a 400 on illegal media type accept headers except for the "*" case which turns it into a "*/*".
> Improve invalid media type toleration
> -------------------------------------
>
> Key: WINK-172
> URL: https://issues.apache.org/jira/browse/WINK-172
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
> The two I think should be corrected:
> "*" turn to MediaType.WILDCARD
> "text/" (missing subtype) turn to "text/*" (or as appropriate)
> The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-172) Improve invalid media type toleration
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752883#action_12752883 ]
Hudson commented on WINK-172:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #136 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/136/])
Tolerate "*" Accept header value
See []
> Improve invalid media type toleration
> -------------------------------------
>
> Key: WINK-172
> URL: https://issues.apache.org/jira/browse/WINK-172
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.2
>
>
> Improve the toleration of invalid media types. Certain common client code send invalid media type headers. For those cases, I think it's easier to just skip invalid media types or to "correct" those media types.
> The two I think should be corrected:
> "*" turn to MediaType.WILDCARD
> "text/" (missing subtype) turn to "text/*" (or as appropriate)
> The rest I think should be tolerated as invalid if possible (i.e. skip the invalid media type).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.