You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/01/05 12:17:12 UTC

Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 12:17 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
-------

Rebased


Bugs: MESOS-4081
    https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
-------

Quota Authorization: Documented quota removal authorization.


Diffs (updated)
-----

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41549/diff/


Testing (updated)
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 41549: Quota: Documented quota removal authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 2:36 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-----------------

Quota: Documented quota removal authorization.


Bugs: MESOS-4081
    https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
-------

Quota Authorization: Documented quota removal authorization.


Diffs
-----

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41549/diff/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 12:16 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
-------

Addressed issues.


Bugs: MESOS-4081
    https://issues.apache.org/jira/browse/MESOS-4081


Repository: mesos


Description
-------

Quota Authorization: Documented quota removal authorization.


Diffs (updated)
-----

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 

Diff: https://reviews.apache.org/r/41549/diff/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/#review112888
-----------------------------------------------------------

Ship it!



docs/authorization.md (line 50)
<https://reviews.apache.org/r/41549/#comment173366>

    s/Principal/Principals/ ?


- Till Toenshoff


On Jan. 5, 2016, 11:17 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41549/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4081
>     https://issues.apache.org/jira/browse/MESOS-4081
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Documented quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 41549: [4/5] Quota Authorization: Documented quota removal authorization.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41549/#review112844
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On Jan. 5, 2016, 11:17 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41549/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 11:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4081
>     https://issues.apache.org/jira/browse/MESOS-4081
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Documented quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d 
> 
> Diff: https://reviews.apache.org/r/41549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>