You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/05/23 21:36:58 UTC
[GitHub] [madlib] njayaram2 opened a new pull request #397: DL: Update
content of the model summary table
njayaram2 opened a new pull request #397: DL: Update content of the model summary table
URL: https://github.com/apache/madlib/pull/397
JIRA: MADLIB-1349, MADLIB-1338
Add a new column named `metrics_type` that captures the metric name
(if) specified in the compile params. This commit also fixes the
model_size reported, it was reporting the wrong size.
There were a few comments in MADLIB-1338 after the corresponding PR was
merged to master. Some of those comments are addressed in this PR since
they are related code, and minor changes.
1. Ensure compile_params cannot be NULL.
2. Update some info messages.
3. Use the @MinWarning decorator to suppress notices.
4. Ensure training_metrics_final and validation_metrics_final are NULL
if the compile params did not have any metric specified.
Co-authored-by: Jingyi Mei <jm...@pivotal.io>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services