You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2023/12/05 09:13:05 UTC
[PR] [DNM](test) add back canEliminate [doris]
morrySnow opened a new pull request, #28017:
URL: https://github.com/apache/doris/pull/28017
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1855490944
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.87 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17222023678 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1857214640
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1849547043
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.76 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17219892266 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1842835232
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.91 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161897242 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1852025972
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.87 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17219882636 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1857173123
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1842768614
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1857214613
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1855433815
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1855582570
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1849493672
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1857192183
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit b4780402b93c9ba5c7e25736bd33f1e43ba0bde4, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4721 4463 4478 4463
q2 369 145 160 145
q3 1464 1259 1220 1220
q4 1116 918 884 884
q5 3181 3139 3165 3139
q6 247 130 127 127
q7 1002 503 488 488
q8 2210 2201 2178 2178
q9 6648 6658 6683 6658
q10 3223 3262 3278 3262
q11 328 200 212 200
q12 353 211 207 207
q13 4570 3810 3801 3801
q14 249 212 214 212
q15 561 525 528 525
q16 449 382 391 382
q17 998 555 593 555
q18 7188 6938 7022 6938
q19 1501 1388 1422 1388
q20 537 290 285 285
q21 3069 2640 2632 2632
q22 345 293 283 283
Total cold run time: 44329 ms
Total hot run time: 39972 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4447 4398 4393 4393
q2 261 163 167 163
q3 3553 3534 3520 3520
q4 2375 2377 2360 2360
q5 5736 5736 5734 5734
q6 243 123 121 121
q7 2386 1889 1851 1851
q8 3515 3510 3509 3509
q9 9038 9045 9017 9017
q10 3933 3971 3999 3971
q11 496 386 394 386
q12 755 600 608 600
q13 4292 3574 3573 3573
q14 282 257 255 255
q15 576 524 521 521
q16 518 468 454 454
q17 1903 1860 1832 1832
q18 8756 8045 8293 8045
q19 1719 1729 1707 1707
q20 2268 1940 1946 1940
q21 6507 6160 6155 6155
q22 510 417 418 417
Total cold run time: 64069 ms
Total hot run time: 60524 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1855771943
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit b4780402b93c9ba5c7e25736bd33f1e43ba0bde4, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4710 4512 4417 4417
q2 364 150 157 150
q3 1466 1239 1238 1238
q4 1113 897 894 894
q5 3170 3157 3155 3155
q6 250 126 126 126
q7 1003 488 474 474
q8 2220 2221 2194 2194
q9 6691 6696 6646 6646
q10 3213 3265 3275 3265
q11 325 214 201 201
q12 353 208 205 205
q13 4552 3781 3806 3781
q14 243 213 209 209
q15 567 529 528 528
q16 443 391 395 391
q17 1005 563 586 563
q18 7143 6919 6984 6919
q19 1529 1397 1431 1397
q20 530 317 287 287
q21 3052 2668 2695 2668
q22 350 275 280 275
Total cold run time: 44292 ms
Total hot run time: 39983 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4384 4370 4408 4370
q2 271 163 173 163
q3 3549 3542 3526 3526
q4 2390 2370 2362 2362
q5 5729 5727 5728 5727
q6 243 121 120 120
q7 2408 1861 1845 1845
q8 3513 3521 3513 3513
q9 9035 9020 9055 9020
q10 3891 3992 4004 3992
q11 503 389 397 389
q12 760 585 598 585
q13 4297 3561 3607 3561
q14 282 255 257 255
q15 575 530 529 529
q16 519 458 467 458
q17 1865 1869 1847 1847
q18 8778 8243 8204 8204
q19 1729 1748 1712 1712
q20 2272 1930 1926 1926
q21 6516 6206 6201 6201
q22 492 421 410 410
Total cold run time: 64001 ms
Total hot run time: 60715 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1849870897
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1852015652
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit dd4927fcf41f10fe329cbffad15e4f29609798dd, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4704 4445 4524 4445
q2 384 170 158 158
q3 1458 1247 1231 1231
q4 1112 921 890 890
q5 3151 3141 3147 3141
q6 254 130 132 130
q7 993 488 467 467
q8 2195 2245 2189 2189
q9 6677 6709 6678 6678
q10 3219 3261 3284 3261
q11 320 207 195 195
q12 353 205 210 205
q13 4575 3787 3804 3787
q14 247 218 214 214
q15 571 525 527 525
q16 439 396 387 387
q17 1011 617 557 557
q18 8136 6997 6990 6990
q19 1539 1469 1318 1318
q20 570 322 316 316
q21 3083 2645 2663 2645
q22 344 275 281 275
Total cold run time: 45335 ms
Total hot run time: 40004 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4408 4405 4406 4405
q2 276 160 173 160
q3 3519 3531 3516 3516
q4 2389 2364 2365 2364
q5 5715 5731 5734 5731
q6 243 120 123 120
q7 2384 1890 1855 1855
q8 3499 3540 3516 3516
q9 9027 8990 8982 8982
q10 3921 3998 4020 3998
q11 498 378 396 378
q12 761 588 596 588
q13 4319 3550 3543 3543
q14 280 255 240 240
q15 574 525 523 523
q16 523 460 465 460
q17 1884 1849 1854 1849
q18 8610 8225 8678 8225
q19 1725 1755 1746 1746
q20 2262 1938 1946 1938
q21 6525 6153 6172 6153
q22 498 402 428 402
Total cold run time: 63840 ms
Total hot run time: 60692 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1849931523
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit fc33857a8589ea27b6b76078376d41b1d8127587, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4642 4457 4466 4457
q2 375 181 159 159
q3 1465 1287 1181 1181
q4 1110 973 918 918
q5 3126 3173 3129 3129
q6 246 128 127 127
q7 1023 494 475 475
q8 2193 2229 2174 2174
q9 6631 6662 6630 6630
q10 3217 3228 3298 3228
q11 335 194 211 194
q12 358 208 206 206
q13 4558 3819 3820 3819
q14 241 211 215 211
q15 562 522 520 520
q16 451 392 392 392
q17 1011 578 529 529
q18 7629 7153 7928 7153
q19 1542 1301 1401 1301
q20 538 847 307 307
q21 3121 2714 2633 2633
q22 356 291 292 291
Total cold run time: 44730 ms
Total hot run time: 40034 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4403 4383 4401 4383
q2 269 163 175 163
q3 3617 3562 3552 3552
q4 2392 2483 2515 2483
q5 5746 5767 5752 5752
q6 238 120 122 120
q7 2390 1854 1888 1854
q8 3522 3513 3531 3513
q9 9040 9041 8982 8982
q10 3901 3996 4004 3996
q11 507 397 386 386
q12 767 597 601 597
q13 4306 3580 3568 3568
q14 291 265 267 265
q15 561 518 522 518
q16 511 469 448 448
q17 1875 1856 1861 1856
q18 8699 8356 8409 8356
q19 1768 1753 1768 1753
q20 2248 1945 1930 1930
q21 6567 6222 6237 6222
q22 498 424 447 424
Total cold run time: 64116 ms
Total hot run time: 61121 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1851901696
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on code in PR #28017:
URL: https://github.com/apache/doris/pull/28017#discussion_r1427565267
##########
regression-test/data/nereids_rules_p0/filter_push_down/push_down_filter_other_condition.out:
##########
@@ -1,382 +1,253 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !pushdown_inner_join --
PhysicalResultSink
---PhysicalDistribute
-----PhysicalProject
-------hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id]
---------filter((t1.id > 1))
-----------PhysicalOlapScan[t1] apply RFs: RF0
---------PhysicalDistribute
-----------filter((t2.id > 1))
-------------PhysicalOlapScan[t2]
+--hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id]
Review Comment:
need to confirm
##########
regression-test/data/nereids_tpcds_shape_sf1000_p0/shape/query10.out:
##########
@@ -5,53 +5,50 @@ PhysicalResultSink
----PhysicalTopN[MERGE_SORT]
------PhysicalDistribute
--------PhysicalTopN[LOCAL_SORT]
-----------hashAgg[GLOBAL]
-------------PhysicalDistribute
---------------hashAgg[LOCAL]
-----------------PhysicalProject
-------------------hashJoin[RIGHT_SEMI_JOIN] hashCondition=((c.c_customer_sk = store_sales.ss_customer_sk)) otherCondition=() build RFs:RF5 c_customer_sk->[ss_customer_sk]
---------------------PhysicalDistribute
-----------------------PhysicalProject
-------------------------hashJoin[INNER_JOIN] hashCondition=((store_sales.ss_sold_date_sk = date_dim.d_date_sk)) otherCondition=() build RFs:RF4 d_date_sk->[ss_sold_date_sk]
+----------hashAgg[LOCAL]
Review Comment:
need to confirm
##########
regression-test/data/nereids_rules_p0/eager_aggregate/basic_one_side.out:
##########
@@ -1,60 +1,40 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !1 --
PhysicalResultSink
---PhysicalDistribute
-----hashAgg[GLOBAL]
-------PhysicalDistribute
+--hashAgg[GLOBAL]
+----hashAgg[LOCAL]
Review Comment:
need to confirm
##########
regression-test/data/nereids_rules_p0/eager_aggregate/basic.out:
##########
@@ -1,63 +1,43 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !1 --
PhysicalResultSink
---PhysicalDistribute
-----hashAgg[GLOBAL]
-------PhysicalDistribute
+--hashAgg[GLOBAL]
Review Comment:
need to confirm
##########
regression-test/data/nereids_rules_p0/infer_set_operator_distinct/infer_set_operator_distinct.out:
##########
@@ -242,23 +272,27 @@ PhysicalResultSink
--------hashAgg[LOCAL]
----------PhysicalUnion
------------PhysicalDistribute
---------------hashJoin[LEFT_SEMI_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=()
-----------------PhysicalOlapScan[t1]
-----------------PhysicalDistribute
-------------------PhysicalProject
---------------------PhysicalOlapScan[t2]
+--------------PhysicalProject
Review Comment:
need to confirm
##########
regression-test/suites/nereids_rules_p0/eager_aggregate/basic.groovy:
##########
@@ -18,6 +18,7 @@
suite("eager_aggregate_basic") {
sql "SET enable_nereids_planner=true"
sql "SET enable_fallback_to_original_planner=false"
+ sql "SET ignore_shape_nodes='PhysicalDistribute,PhysicalProject'"
Review Comment:
need to confirm
##########
regression-test/data/nereids_rules_p0/predicate_infer/infer_predicate.out:
##########
@@ -1,565 +1,397 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !infer_predicate_basic_join --
PhysicalResultSink
---PhysicalDistribute
-----PhysicalProject
-------hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id]
---------PhysicalOlapScan[t] apply RFs: RF0
---------filter((t1.score > 10))
-----------PhysicalOlapScan[t]
+--hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=()
Review Comment:
need to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1857201958
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.46 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17216883291 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1849534837
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 6439e1bba3f2f620ae9c862934fce79409f2c31b, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4628 4464 4487 4464
q2 378 147 157 147
q3 1472 1233 1242 1233
q4 1115 928 928 928
q5 3149 3136 3179 3136
q6 247 127 124 124
q7 1000 483 476 476
q8 2219 2219 2199 2199
q9 6663 6679 6700 6679
q10 3238 3254 3268 3254
q11 326 195 202 195
q12 354 207 214 207
q13 4561 3843 3807 3807
q14 241 215 212 212
q15 554 528 525 525
q16 445 397 394 394
q17 1013 573 600 573
q18 8175 7487 6989 6989
q19 1531 1391 1490 1391
q20 515 326 310 310
q21 3112 2669 2636 2636
q22 348 280 284 280
Total cold run time: 45284 ms
Total hot run time: 40159 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4389 4387 4358 4358
q2 268 159 172 159
q3 3558 3536 3554 3536
q4 2392 2374 2377 2374
q5 5765 5746 5742 5742
q6 240 124 122 122
q7 2408 1885 1836 1836
q8 3524 3536 3518 3518
q9 9101 9024 9059 9024
q10 3913 3994 3992 3992
q11 503 390 387 387
q12 767 599 602 599
q13 4297 3591 3542 3542
q14 291 260 259 259
q15 566 522 530 522
q16 506 441 497 441
q17 1902 1862 1868 1862
q18 8792 8237 8765 8237
q19 1743 1765 1738 1738
q20 2240 1932 1929 1929
q21 6563 6227 6204 6204
q22 518 429 411 411
Total cold run time: 64246 ms
Total hot run time: 60792 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1855519154
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 3a55944afe30bf5b7c5b93676eb69c96ee185524, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4726 4470 4475 4470
q2 363 151 159 151
q3 1464 1264 1249 1249
q4 1107 905 912 905
q5 3162 3136 3178 3136
q6 242 125 124 124
q7 971 489 480 480
q8 2186 2204 2181 2181
q9 6652 6685 6662 6662
q10 3204 3283 3278 3278
q11 330 213 198 198
q12 347 209 206 206
q13 4544 3818 3843 3818
q14 244 211 220 211
q15 569 525 530 525
q16 437 380 384 380
q17 997 604 571 571
q18 7145 6916 6861 6861
q19 1513 1334 1428 1334
q20 495 335 304 304
q21 3040 2647 2621 2621
q22 348 280 289 280
Total cold run time: 44086 ms
Total hot run time: 39945 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4389 4386 4397 4386
q2 268 165 167 165
q3 3524 3522 3503 3503
q4 2390 2375 2377 2375
q5 5718 5711 5718 5711
q6 240 125 122 122
q7 2377 1908 1888 1888
q8 3509 3517 3526 3517
q9 9007 9029 8979 8979
q10 3901 3981 3980 3980
q11 507 391 379 379
q12 759 597 589 589
q13 4281 3596 3574 3574
q14 284 247 260 247
q15 572 520 538 520
q16 494 441 452 441
q17 1868 1842 1843 1842
q18 8579 8095 8270 8095
q19 1735 1709 1737 1709
q20 2259 1948 1941 1941
q21 6510 6198 6144 6144
q22 503 424 432 424
Total cold run time: 63674 ms
Total hot run time: 60531 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [DNM](test) add back canEliminate [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28017:
URL: https://github.com/apache/doris/pull/28017#issuecomment-1843006231
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 3ca737e532a032f90389952ec896406319e1cf06, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4746 4485 4457 4457
q2 364 161 160 160
q3 1462 1242 1184 1184
q4 1111 932 892 892
q5 3169 3143 3178 3143
q6 249 128 127 127
q7 969 504 489 489
q8 2216 2196 2182 2182
q9 6702 6688 6698 6688
q10 3222 3253 3278 3253
q11 324 200 205 200
q12 351 212 211 211
q13 4599 3801 3808 3801
q14 241 217 208 208
q15 564 524 522 522
q16 458 390 397 390
q17 1014 580 575 575
q18 7547 7091 6867 6867
q19 1525 1385 1382 1382
q20 507 327 324 324
q21 3078 2684 2688 2684
q22 357 287 294 287
Total cold run time: 44775 ms
Total hot run time: 40026 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4414 4403 4426 4403
q2 274 164 177 164
q3 3537 3526 3511 3511
q4 2417 2394 2400 2394
q5 5777 5756 5745 5745
q6 238 120 122 120
q7 2410 1905 1869 1869
q8 3528 3538 3516 3516
q9 9056 9035 9030 9030
q10 3908 3983 4001 3983
q11 504 391 381 381
q12 771 590 602 590
q13 4313 3561 3535 3535
q14 277 248 257 248
q15 579 516 530 516
q16 510 455 470 455
q17 1878 1844 1893 1844
q18 8778 8284 9141 8284
q19 1708 1728 1725 1725
q20 2250 1944 1949 1944
q21 6509 6173 6189 6173
q22 496 424 419 419
Total cold run time: 64132 ms
Total hot run time: 60849 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [perf](Nereids) add back canEliminate temporary [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #28017:
URL: https://github.com/apache/doris/pull/28017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org