[GitHub] [yunikorn-release] HuangTing-Yao commented on a diff in pull request #106: [YUNIKORN-156] license check for release repo

[GitBox <gi...@apache.org>]

HuangTing-Yao commented on code in PR #106:
URL: https://github.com/apache/yunikorn-release/pull/106#discussion_r968183845


##########
check_license.sh:
##########
@@ -0,0 +1,38 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Kernel (OS) Name
+OS=$(uname -s | tr '[:upper:]' '[:lower:]')
+# show that the check has started
+echo "checking license headers:"
+# run different finds on mac vs linux
+if [ "${OS}" = "darwin" ]; then
+  find -E . ! -path "./.git*" -regex ".*(Makefile|\.(go|sh|py|md|conf|yaml|yml|tpl))" -exec grep -L "Licensed to the Apache Software Foundation" {} \; > LICRES
+else
+  find . ! -path "./.git*" -regex ".*\(Makefile\|\.\(go\|py\|sh\|md\|yaml\|yml\|tpl\)\)" -exec grep -L "Licensed to the Apache Software Foundation" {} \; > LICRES

Review Comment:
   I think we the `conf` is missing in this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org