You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:42:40 UTC

[GitHub] [skywalking] arugal commented on a change in pull request #5390: Support IN filter expressions in OAL

arugal commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477173735



##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,42 @@
 
 package org.apache.skywalking.oal.rt.parser;
 
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 
 @Getter
 @Setter
 @NoArgsConstructor
-@AllArgsConstructor
 public class ConditionExpression {
     // original from script
     private String expressionType;
     private String attribute;
     private String value;
+

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org