[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1509: [CELEBORN-604][SPARK] Support Spark 3.4

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1509:
URL: https://github.com/apache/incubator-celeborn/pull/1509#discussion_r1204027320


##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -191,8 +190,13 @@ public void write(scala.collection.Iterator<Product2<K, V>> records) throws IOEx
 
   @VisibleForTesting
   boolean canUseFastWrite() {

Review Comment:
   > @waitinfuture do you have benchmark results, how fast can this achieve?
   
   I think it can make a big difference because UnsafeRow's serializer just copy memory from UnsafeRow. Though I haven't benchmark it. We can do a benchmark if necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org