You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 15:35:57 UTC
[GitHub] [spark] Shockang opened a new pull request #34243: [SPARK-36853][BUILD]Code failing on checkstyle
Shockang opened a new pull request #34243:
URL: https://github.com/apache/spark/pull/34243
### What changes were proposed in this pull request?
Fixed the checkstyle error thrown in windows in maven installing phase.
### Why are the changes needed?
Due to some problems in CI system, these obvious errors have not been detected. I think these checkstyle errors should be solved.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No, there is no need to provide test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Shockang closed pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
Shockang closed pull request #34243:
URL: https://github.com/apache/spark/pull/34243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-994168174
Ping @Shockang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34243: [SPARK-36853][BUILD]Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-940161186
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Shockang commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
Shockang commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-1000981481
The submitted code is transferred to this PR: https://github.com/apache/spark/pull/35017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-941220184
Yep disable the naming rule. The line length changes are OK. Does everything pass then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34243:
URL: https://github.com/apache/spark/pull/34243#discussion_r726679682
##########
File path: sql/core/src/main/java/org/apache/spark/sql/streaming/Trigger.java
##########
@@ -41,7 +41,7 @@
*
* @since 2.2.0
*/
- public static Trigger ProcessingTime(long intervalMs) {
+ public static Trigger processingTime(long intervalMs) {
Review comment:
This kind of change breaks backward compatibility. We will have to make it skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-940564274
> No, there is no need to provide test cases.
We should describe how you identified these instances, and how you verify it. I guess you faced those errors on Window, right? It should be best to describe what command you ran in which OS so other people can reproduce this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Shockang commented on pull request #34243: [SPARK-36853][BUILD]Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
Shockang commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-940148511
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-941220184
Yep disable the naming rule. The line length changes are OK. Does everything pass then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Shockang commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
Shockang commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-943002998
> > No, there is no need to provide test cases.
>
> We should describe how you identified these instances, and how you verify it. I guess you faced those errors on Window, right? It should be best to describe what command you ran in which OS so other people can reproduce this.
I can't agree more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Shockang commented on pull request #34243: [SPARK-36853][BUILD] Code failing on checkstyle
Posted by GitBox <gi...@apache.org>.
Shockang commented on pull request #34243:
URL: https://github.com/apache/spark/pull/34243#issuecomment-995474209
> Ping @Shockang
OK, I'll deal with this problem as soon as possible. I've been busy recently :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org