[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40676: [SPARK-42656][FOLLOWUP] Add BUILD and SCCLASSPATH options to Spark Connect scripts

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #40676:
URL: https://github.com/apache/spark/pull/40676#discussion_r1160381167


##########
connector/connect/bin/spark-connect:
##########
@@ -30,8 +30,11 @@ export SPARK_HOME=$FWDIR
 SCALA_BINARY_VER=`grep "scala.binary.version" "${SPARK_HOME}/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}'`
 SCALA_ARG="-Pscala-${SCALA_BINARY_VER}"
 
-# Build the jars needed for spark submit and spark connect
-build/sbt "${SCALA_ARG}" -Phive -Pconnect package
+BUILD="${BUILD:-1}"

Review Comment:
   Sorry for a posthoc review. I wonder if we should better pick a different name though. `BUILD` might be too common ..  and that might easily conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org