[jira] [Commented] (FLINK-3472) JDBCInputFormat.nextRecord(..) has misleading message on NPE

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184800#comment-15184800 ] 

ASF GitHub Bot commented on FLINK-3472:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1772

    [FLINK-3472] Better exception if jdbc field is null

    Provides a better exception message if the JDBC InputFormat encounters a null field.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3472_jdbc_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1772
    
----
commit 98ca24ca3ac3cd353acc0b56e1c3b9d0d218a497
Author: zentol <s....@web.de>
Date:   2016-03-08T10:49:07Z

    [FLINK-3472] Better exception if jdbc field is null

----


> JDBCInputFormat.nextRecord(..) has misleading message on NPE
> ------------------------------------------------------------
>
>                 Key: FLINK-3472
>                 URL: https://issues.apache.org/jira/browse/FLINK-3472
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 0.10.2
>            Reporter: Ken Geis
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> JDBCInputFormat.nextRecord(..) assumes that a NullPointerException could only occur by the resultSet being null. It rethrows an exception with the message "Couldn't access resultSet". See FLINK-3471 for an example of where the NPE could come from another situation. Either the message should be changed or the scope of the try/catch should be tightened around the {{resultSet.next();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)