You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/28 16:47:18 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #11487: Add backoff for setting for getting topic policies.

codelipenghui opened a new pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487


   ### Motivation
   
   Currently, if we start a new broker which does not owned any namepsaces bundles.
   Then when use the pulsar-admin to setting or getting topic policies, we will get
   `topic policies have not been initialized yet` error log and the admin operation will
   get failed.
   
   The root cause is we are failed immediately without any retry while the topic polices
   cache have not init yet. So the PR to introduce the backoff for setting or getting
   the topic policy if encounter the topic policies cache not init exception
   
   ### Verifying this change
   
   Remove the cache init check for the tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487#discussion_r679197835



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicPoliciesService.java
##########
@@ -80,13 +80,6 @@
      */
     void start();
 
-    /**
-     * whether the cache has been initialized.
-     * @param topicName
-     * @return
-     */
-    boolean cacheIsInitialized(TopicName topicName);

Review comment:
       ok 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487#issuecomment-889187722


   Good job!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487#discussion_r679191261



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicPoliciesService.java
##########
@@ -80,13 +80,6 @@
      */
     void start();
 
-    /**
-     * whether the cache has been initialized.
-     * @param topicName
-     * @return
-     */
-    boolean cacheIsInitialized(TopicName topicName);

Review comment:
       The interface mark as Deprecated instead of directly delete?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11487: Add backoff for setting for getting topic policies.

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11487:
URL: https://github.com/apache/pulsar/pull/11487#discussion_r679196352



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicPoliciesService.java
##########
@@ -80,13 +80,6 @@
      */
     void start();
 
-    /**
-     * whether the cache has been initialized.
-     * @param topicName
-     * @return
-     */
-    boolean cacheIsInitialized(TopicName topicName);

Review comment:
       This method does not been used by the client-side, after checking the reference to this method, all of them are from the test class, I think we can delete it directly since we are not exposing the interface for users to implement their own topic policies service implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org