You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/02/21 06:48:01 UTC
[GitHub] [tez] amanraj2520 opened a new pull request, #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
amanraj2520 opened a new pull request, #272:
URL: https://github.com/apache/tez/pull/272
Upgraded Hadoop to 3.3.4 and some dependency imports for tests.
Have successfully tested in my local running all the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439704243
Just FYI why I made this change in tez-tests
This issue comes when PowerMock library conflicts with Mockito as described here https://stackoverflow.com/questions/71973762/java-lang-nosuchmethoderror-org-mockito-answers-getlorg-mockito-stubbing-answ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439702484
Just FYI why I made the change in tez-tests :
image
I see these test failures in the tez-tests module. Currently fixing it @abstractdog @steveloughran This issue comes when PowerMock library conflicts with Mockito as described here https://stackoverflow.com/questions/71973762/java-lang-nosuchmethoderror-org-mockito-answers-getlorg-mockito-stubbing-answ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1437938453
@abstractdog I have tested all tests in my local. The only test failure was TestLocalMode previously which I see you have fixed recently in master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439944886
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 45s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 37s | master passed |
| +1 :green_heart: | compile | 3m 22s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 43s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 3m 0s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 20s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 31s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 21s | the patch passed |
| +1 :green_heart: | compile | 3m 0s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 3m 0s | the patch passed |
| +1 :green_heart: | compile | 2m 58s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 58s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 47s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 19s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 43m 27s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 75m 5s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 0s | The patch does not generate ASF License warnings. |
| | | 168m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 799d1d644ad0 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/2/testReport/ |
| Max. process+thread count | 2101 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/2/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439718807
@abstractdog Can you please review this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441586082
Just for everyone's knowledge, if we do not include mockito-core, the tests will fail with the following errors:
`[INFO] Running org.apache.tez.mapreduce.TestMRRJobsDAGApi
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.92 s <<< FAILURE! - in org.apache.tez.mapreduce.TestMRRJobsDAGApi
[ERROR] org.apache.tez.mapreduce.TestMRRJobsDAGApi Time elapsed: 2.914 s <<< ERROR!
java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
at org.apache.tez.mapreduce.TestMRRJobsDAGApi.setup(TestMRRJobsDAGApi.java:156)
Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer
at org.apache.tez.mapreduce.TestMRRJobsDAGApi.setup(TestMRRJobsDAGApi.java:156)
[INFO] Running org.apache.tez.mapreduce.TestMRRJobs
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.416 s <<< FAILURE! - in org.apache.tez.mapreduce.TestMRRJobs
[ERROR] org.apache.tez.mapreduce.TestMRRJobs Time elapsed: 3.412 s <<< ERROR!
java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
at org.apache.tez.mapreduce.TestMRRJobs.setup(TestMRRJobs.java:71)
Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer
at org.apache.tez.mapreduce.TestMRRJobs.setup(TestMRRJobs.java:71)
[INFO] Running org.apache.tez.test.TestAM
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.019 s <<< FAILURE! - in org.apache.tez.test.TestAM
[ERROR] org.apache.tez.test.TestAM Time elapsed: 3.015 s <<< ERROR!
java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
at org.apache.tez.test.TestAM.setup(TestAM.java:66)
Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer
at org.apache.tez.test.TestAM.setup(TestAM.java:66)
[INFO] Running org.apache.tez.test.TestAMRecovery
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.463 s <<< FAILURE! - in org.apache.tez.test.TestAMRecovery
[ERROR] org.apache.tez.test.TestAMRecovery Time elapsed: 3.46 s <<< ERROR!
java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
at org.apache.tez.test.TestAMRecovery.beforeClass(TestAMRecovery.java:109)
Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer
at org.apache.tez.test.TestAMRecovery.beforeClass(TestAMRecovery.java:109)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on a diff in pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on code in PR #272:
URL: https://github.com/apache/tez/pull/272#discussion_r1113984767
##########
tez-tests/pom.xml:
##########
@@ -124,11 +124,34 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <version>2.18.0</version>
Review Comment:
You are right. I missed this declaration. Will make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441576663
Hi @abstractdog Sorry my bad. I checked the Hadoop 3.3.4 version in my local repo. It had the use of powermock libraries which I was using to debug and mock some functionalities for branch-3 (Hive) upgrade with Hadoop 3.3.4. These were unnecessary changes. I refreshed my local and deleted all the jars. Now it downloaded oss Hadoop 3.3.4 and built correctly. We only need to include mockito-core for the tez-tests that's it. I have pushed my commit. Kindly check it once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] steveloughran commented on a diff in pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on code in PR #272:
URL: https://github.com/apache/tez/pull/272#discussion_r1114165412
##########
tez-tests/pom.xml:
##########
@@ -129,6 +129,23 @@
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.powermock</groupId>
+ <artifactId>powermock-api-mockito2</artifactId>
+ <version>2.0.2</version>
Review Comment:
not a tez committer, but I'd expect that dependency version to be set in the base pom.xml and referenced twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] steveloughran commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1443836215
nice. well done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439937619
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 54s | master passed |
| +1 :green_heart: | compile | 2m 54s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 50s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 2m 43s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 20s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 29s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 41s | the patch passed |
| +1 :green_heart: | compile | 2m 55s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 2m 55s | the patch passed |
| +1 :green_heart: | compile | 2m 38s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 38s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 36s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 17s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 40m 34s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 74m 1s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 53s | The patch does not generate ASF License warnings. |
| | | 160m 57s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux eea1ef9795f7 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/3/testReport/ |
| Max. process+thread count | 1484 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/3/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1440308824
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 8m 7s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 2s | master passed |
| +1 :green_heart: | compile | 2m 45s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 30s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 2m 37s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 3s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 25s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 34s | the patch passed |
| +1 :green_heart: | compile | 2m 47s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 2m 47s | the patch passed |
| +1 :green_heart: | compile | 2m 32s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 32s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 26s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 4s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 39m 17s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 71m 13s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. |
| | | 156m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 33830db250b2 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/5/testReport/ |
| Max. process+thread count | 2090 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/5/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441578178
@abstractdog Added a snapshot of a sample successful test which was failing earlier :
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441442000
@abstractdog Can you please review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1439964995
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 22m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 42s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 42s | master passed |
| +1 :green_heart: | compile | 2m 43s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 32s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 2m 40s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 12s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 28s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 11s | the patch passed |
| +1 :green_heart: | compile | 2m 41s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 2m 42s | the patch passed |
| +1 :green_heart: | compile | 2m 33s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 33s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 32s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 11s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 41m 55s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 73m 3s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. |
| | | 182m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux b271ffc1365e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/4/testReport/ |
| Max. process+thread count | 2100 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/4/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441456693
> Just FYI why I made this change in tez-tests This issue comes when PowerMock library conflicts with Mockito as described here https://stackoverflow.com/questions/71973762/java-lang-nosuchmethoderror-org-mockito-answers-getlorg-mockito-stubbing-answ
I cannot see powermock used by tez, so assuming that the powermock used by hadoop conflicts with the mockito used by tez? is that right? if so, theoretically, this conflict can be resolved in the future in case of a mockito version change in tez or rather a powermock version change in hadoop (as mockito is quite new one in tez since TEZ-4383)
please clarify this scenario here by an xml comment: pom.xmls are full of dependencies without any context and hence extremely easy to break, I would like to see the explanation here (any comment that clarifies my points above is welcome :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog merged pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #272:
URL: https://github.com/apache/tez/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1438143422
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 49s | master passed |
| +1 :green_heart: | compile | 3m 5s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 38s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 2m 58s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 14s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 28s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 45s | the patch passed |
| +1 :green_heart: | compile | 2m 59s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 2m 59s | the patch passed |
| +1 :green_heart: | compile | 2m 41s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 41s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 30s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 6s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 39m 24s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 73m 24s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. |
| | | 160m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux a1e66b6517f6 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/1/testReport/ |
| Max. process+thread count | 1385 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/1/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] amanraj2520 commented on a diff in pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on code in PR #272:
URL: https://github.com/apache/tez/pull/272#discussion_r1114322141
##########
tez-tests/pom.xml:
##########
@@ -129,6 +129,23 @@
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.powermock</groupId>
+ <artifactId>powermock-api-mockito2</artifactId>
+ <version>2.0.2</version>
Review Comment:
Addressed your concerns. Thanks for the suggestion @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #272:
URL: https://github.com/apache/tez/pull/272#issuecomment-1441817067
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 6m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 9s | master passed |
| +1 :green_heart: | compile | 2m 47s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | compile | 2m 32s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javadoc | 2m 35s | master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 6s | master passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 1m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 31s | the patch passed |
| +1 :green_heart: | compile | 2m 47s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javac | 2m 47s | the patch passed |
| +1 :green_heart: | compile | 2m 31s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| +1 :green_heart: | javac | 2m 31s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 24s | the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 |
| +1 :green_heart: | javadoc | 2m 2s | the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 39m 47s | tez-tests in the patch passed. |
| +1 :green_heart: | unit | 67m 27s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 152m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/272 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 5d791a3b716f 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / be994890d |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu222.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~22.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/6/testReport/ |
| Max. process+thread count | 2090 (vs. ulimit of 5500) |
| modules | C: tez-tests . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-272/6/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on a diff in pull request #272: TEZ-4420 : Upgrade Hadoop to 3.3.4
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #272:
URL: https://github.com/apache/tez/pull/272#discussion_r1113872811
##########
tez-tests/pom.xml:
##########
@@ -124,11 +124,34 @@
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+ <version>2.18.0</version>
Review Comment:
this test-scoped dependency is included twice in this pom, is that intentional? also, its version differs from the one in the root pom (4.3.1), can you place a comment here about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org