You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/07 07:54:29 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4774:
Refactor virtualColumn
codecov-io edited a comment on issue #4774: Refactor virtualColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#issuecomment-548993487
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=h1) Report
> Merging [#4774](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/343aadb28058ea4fbb38ef17887f0ce19ef8c5be?src=pr&el=desc) will **decrease** coverage by `19.92%`.
> The diff coverage is `83.78%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4774 +/- ##
=============================================
- Coverage 57.7% 37.78% -19.93%
=============================================
Files 1211 1209 -2
Lines 65572 65570 -2
Branches 9560 9561 +1
=============================================
- Hits 37841 24775 -13066
- Misses 24854 38539 +13685
+ Partials 2877 2256 -621
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ment/virtualcolumn/DocIdVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vRG9jSWRWaXJ0dWFsQ29sdW1uUHJvdmlkZXIuamF2YQ==) | `69.23% <100%> (-3.27%)` | `0 <0> (ø)` | |
| [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvaW1tdXRhYmxlL0ltbXV0YWJsZVNlZ21lbnRMb2FkZXIuamF2YQ==) | `89.79% <100%> (-2.37%)` | `0 <0> (ø)` | |
| [...gment/virtualcolumn/BaseVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vQmFzZVZpcnR1YWxDb2x1bW5Qcm92aWRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rtualcolumn/SingleStringVirtualColumnProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vU2luZ2xlU3RyaW5nVmlydHVhbENvbHVtblByb3ZpZGVyLmphdmE=) | `51.42% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <100%> (-1.54%)` | `0 <0> (ø)` | |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `66.56% <100%> (-16.87%)` | `0 <0> (ø)` | |
| [...re/segment/virtualcolumn/VirtualColumnContext.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtbkNvbnRleHQuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/pinot/common/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `78.57% <100%> (-21.43%)` | `0 <0> (ø)` | |
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `32.07% <50%> (-0.62%)` | `0 <0> (ø)` | |
| [...nt/virtualcolumn/VirtualColumnProviderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L3ZpcnR1YWxjb2x1bW4vVmlydHVhbENvbHVtblByb3ZpZGVyRmFjdG9yeS5qYXZh) | `56.25% <61.53%> (-16.48%)` | `0 <0> (ø)` | |
| ... and [603 more](https://codecov.io/gh/apache/incubator-pinot/pull/4774/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=footer). Last update [343aadb...72aa312](https://codecov.io/gh/apache/incubator-pinot/pull/4774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org