You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2024/05/29 23:37:10 UTC

[PR] fix(dashboard): unable to resize due to the overlapped droptarget [superset]

justinpark opened a new pull request, #28772:
URL: https://github.com/apache/superset/pull/28772

   ### SUMMARY
   This commit fixes the resizing issues on last item in #28746 and #28395 by applying the inset location only while dragging.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   ![ChartResize-ezgif com-optimize (1)](https://github.com/apache/superset/assets/92495987/dcc4b1ce-d6b6-4a27-aa7f-1c0671a3dbdd)
   
   After:
   
   https://github.com/apache/superset/assets/1392866/47128359-f69b-4cf9-a2f3-db4b3d2e6f21
   
   
   ### TESTING INSTRUCTIONS
   Extend a widget to the entire width, then resize it again to narrow it down.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): unable to resize due to the overlapped droptarget [superset]

Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #28772:
URL: https://github.com/apache/superset/pull/28772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): unable to resize due to the overlapped droptarget [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #28772:
URL: https://github.com/apache/superset/pull/28772#issuecomment-2139328896

   @rtexelm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): unable to resize due to the overlapped droptarget [superset]

Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #28772:
URL: https://github.com/apache/superset/pull/28772#issuecomment-2140496767

   @rtexelm could you help this code review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org