You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/11/14 14:57:52 UTC
[kudu-CR] [master] CA management: added SysTable base class
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5063
Change subject: [master] CA management: added SysTable base class
......................................................................
[master] CA management: added SysTable base class
Separated common functionality from the SysCatalogTable class into
the SysTable class. The SysCatalogTable extends the functionality
of the SysTable class to work with table and tablet metadata. The new
SysCaInfoTable class is to extend the SysTable class with functionality
specific to storing and reading data needed for certificate authority
management.
Change-Id: I00ccb45cd01cc63b044e5ffe4b3e194ae68cdb66
---
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
A src/kudu/master/sys_ca.cc
A src/kudu/master/sys_ca.h
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
A src/kudu/master/sys_table.cc
A src/kudu/master/sys_table.h
8 files changed, 764 insertions(+), 439 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/5063/1
--
To view, visit http://gerrit.cloudera.org:8080/5063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00ccb45cd01cc63b044e5ffe4b3e194ae68cdb66
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] CA management: added SysTable base class
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.
Change subject: [master] CA management: added SysTable base class
......................................................................
Abandoned
Abandoned in favor of https://gerrit.cloudera.org/#/c/5793/
--
To view, visit http://gerrit.cloudera.org:8080/5063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I00ccb45cd01cc63b044e5ffe4b3e194ae68cdb66
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [master] CA management: added SysTable base class
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [master] CA management: added SysTable base class
......................................................................
Patch Set 1:
Unfortunately I don't think this approach is going to work.
We originally had something like this, with separate catalog tablets for 'tablets' and 'tables' metadata. But then when we got to doing HA, we realized it didn't really work because we needed the concept of which master was "the leader", and if you have more than one tablet, it's quite possible that leadership duties are split between them, making a lot of logic more complicated.
So, rather than do this, I think we should just extend the current sys_catalog with another protobuf entry type. Our design is a bit ugly in that we are using our lovely schemaful structured storage mechanism to store protobuf blobs in a key/value schema, but it simplifies the HA story quite a bit.
If you want to see the historical context, check out commit 77fab0e20c8641aea751daa5ce05eae879fcec09
--
To view, visit http://gerrit.cloudera.org:8080/5063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00ccb45cd01cc63b044e5ffe4b3e194ae68cdb66
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [master] CA management: added SysTable base class
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [master] CA management: added SysTable base class
......................................................................
Patch Set 1:
> Unfortunately I don't think this approach is going to work.
>
> We originally had something like this, with separate catalog
> tablets for 'tablets' and 'tables' metadata. But then when we got
> to doing HA, we realized it didn't really work because we needed
> the concept of which master was "the leader", and if you have more
> than one tablet, it's quite possible that leadership duties are
> split between them, making a lot of logic more complicated.
>
> So, rather than do this, I think we should just extend the current
> sys_catalog with another protobuf entry type. Our design is a bit
> ugly in that we are using our lovely schemaful structured storage
> mechanism to store protobuf blobs in a key/value schema, but it
> simplifies the HA story quite a bit.
>
> If you want to see the historical context, check out commit
> 77fab0e20c8641aea751daa5ce05eae879fcec09
Todd, thank you for the analysis and the reference. I'll amend this patch as you suggest.
--
To view, visit http://gerrit.cloudera.org:8080/5063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00ccb45cd01cc63b044e5ffe4b3e194ae68cdb66
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No