You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/04 14:05:19 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #462: quickjs: Don't define __NuttX__ manually

xiaoxiang781216 opened a new pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462


   ## Summary
   Since nuttx/tools/Config.mk will do it for us: https://github.com/apache/incubator-nuttx/pull/2192
   
   ## Impact
   No functional change
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462#issuecomment-721771659


   It's been `__NuttX__` for a long time in the OS and I believe in buildroot so hard to change. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 merged pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462#issuecomment-722198137


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462#issuecomment-722105968


   @davids5 ```__NuttX__``` isn't invented by quickjs porting, which just follow other library practice(e.g. libc++).  It's hard to change this macro now, because all place(library and toolchain) refernce it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] btashton edited a comment on pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462#issuecomment-721771659


   @davids5 It's been `__NuttX__` for a long time in the OS and I believe in buildroot so hard to change. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #462: quickjs: Don't define __NuttX__ manually

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #462:
URL: https://github.com/apache/incubator-nuttx-apps/pull/462#issuecomment-722105968


   @davids5 ```__NuttX__``` isn't invented by quickjs porting, which just follow other library practice(e.g. libc++).  It's hard to change this macro now, because all place library and toolchain refernce it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org