You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/05/15 07:26:53 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #3330: server: add
newline to the SSH key content
rhtyd opened a new pull request #3330: server: add newline to the SSH key content
URL: https://github.com/apache/cloudstack/pull/3330
On first startup, the management server instantiates and saves random
ssh keys in the database by calling a `trim()` on the string data. On
latest CentOS7 release (CentOS Linux release 7.6.1810 (Core)) I could
reproduce the issue where router_proxy (ssh) did not fail and kept
prompting for passphrase. By adding a newline to the id_rsa.cloud private
key it did not prompt the same. This may likely be an environmental bug.
The patch fixes the issue by adding a newline at the end of the generated
SSH public/private keys in the DB.
SSH packages details:
libssh2.x86_64 1.4.3-12.el7_6.2 @updates
openssh.x86_64 7.4p1-16.el7 @anaconda
openssh-askpass.x86_64 7.4p1-16.el7 @base
openssh-clients.x86_64 7.4p1-16.el7 @anaconda
openssh-server.x86_64 7.4p1-16.el7 @anaconda
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services