You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Julien Le Dem (JIRA)" <ji...@apache.org> on 2012/09/12 02:07:08 UTC
[jira] [Created] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Julien Le Dem created PIG-2913:
----------------------------------
Summary: org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
Key: PIG-2913
URL: https://issues.apache.org/jira/browse/PIG-2913
Project: Pig
Issue Type: Bug
Reporter: Julien Le Dem
Assignee: Julien Le Dem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2913:
-------------------------------
Attachment: PIG-2913.patch
PIG-2913.patch fixes this by turning off loading conf file in this case
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2913:
-------------------------------
Patch Info: Patch Available
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2913:
-------------------------------
Assignee: Cheolsoo Park (was: Julien Le Dem)
looks good to me. I will check it passes and check it in
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913-3.patch, PIG-2913-4.patch, PIG-2913-5.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Attachment: PIG-2913-3.patch
Moved testRegisterRemoteScript to TestPigServer.
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913-3.patch, PIG-2913-4.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483392#comment-13483392 ]
Cheolsoo Park commented on PIG-2913:
------------------------------------
OK, I will move it back to TestPigServer. Thanks for commenting on this, Rohini.
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Attachment: PIG-2913-5.patch
Updating the patch with no whitespace changes.
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913-3.patch, PIG-2913-4.patch, PIG-2913-5.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453713#comment-13453713 ]
Rohini Palaniswamy commented on PIG-2913:
-----------------------------------------
Julien,
The name testRegisterRemoteMacro was confusing when all it does was registering a macro from local filesystem while one would expect a testcase for s3 or hdfs imports. So looked up the history of the test case. As suspected, it was added in PIG-2565 for picking the macro from a hdfs file. With the refactor done in PIG-2866 when macro tests in TestPigServer were moved to TestPigServerWithMacros, it became local FS instead of HDFS and the intent of the test case was lost. Could you make it a MiniCluster instead of new Configuration(false)?
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Attachment: PIG-2913-4.patch
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913-3.patch, PIG-2913-4.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Attachment: PIG-2913-2.patch
I don't know if Julien is working on this, but here is a patch that does what Rohini is asking for. I am doing it since I am fixing tests now anyway.
I re-factored the code so that the "remote" test cases use a Minicluster while the other test cases use local file system.
One question that I had was "why testRegisterRemoteScript is in this test suite although it's not a macro test case?" I didn't move it, but please let me know if you think that it should be moved to somewhere else.
Thanks!
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913-2.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Status: Patch Available (was: Open)
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913-2.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Fix Version/s: 0.11
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2913:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
+1
committed both in branch 0.11 and trunk
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913-3.patch, PIG-2913-4.patch, PIG-2913-5.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483379#comment-13483379 ]
Rohini Palaniswamy commented on PIG-2913:
-----------------------------------------
bq. One question that I had was "why testRegisterRemoteScript is in this test suite although it's not a macro test case?" I didn't move it, but please let me know if you think that it should be moved to somewhere else.
Agree on this one. It does not fit here. We should move it back to TestPigServer.
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2913-2.patch, PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2913)
org.apache.pig.test.TestPigServerWithMacros fails sometimes because it
picks up previous minicluster configuration file
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2913:
-------------------------------
Issue Type: Sub-task (was: Bug)
Parent: PIG-2972
> org.apache.pig.test.TestPigServerWithMacros fails sometimes because it picks up previous minicluster configuration file
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2913
> URL: https://issues.apache.org/jira/browse/PIG-2913
> Project: Pig
> Issue Type: Sub-task
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2913.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira