[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning commented on a diff in pull request #8: Update package and conf to pekko

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158944754


##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
   override def deleteObject(persistenceId: String): CompletionStage[Done] =
     scalaStore.deleteObject(persistenceId).toJava
 
+  override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =

Review Comment:
   this is fine - we've got similar changes in the other pekko-persistence-* projects - we should consider supporting the revision flag but we could do this later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org