You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/02/07 16:33:43 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #448: Update LICENSE, NONOTICE and remove NOLICENSE
Shanedell opened a new pull request, #448:
URL: https://github.com/apache/daffodil-vscode/pull/448
Update LICENSE, NONOTICE and remove NOLICENSE:
- Delete build/package/NOLICENSE as any dependecy with NOLICENSE can't be used.
- Move the files that were listed to LICENSE file.
- Add build/extension.webpack.config.js to LICENSE file.
- Remove yarn dev dependencies from LICENSE and NOTICE files.
- Make sure yarn production dependcies only are listed in the LICENSE and NOTICE files.
- Rename omega-edit-scala-server to omega-edit-grpc-server in LICENSE and NOTICE files as the package name was renamed.
- Add some missing dependencies from omega-edit-grpc-server package to the LICENSE, NOTICE and NONOTICE files/
Closes #375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1101840180
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
Actually, it looks like this might be an issue with the yarn licenses command: [yarnpkg/yarn#2567)](https://togithub.com/yarnpkg/yarn/issues/2567)
That bug is marked as closed, but there are reports that it's still broken.
If you used `yarn list --production`, that's probably the right list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1107132833
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
Sorry for the delay in looking at this. I ran `yarn list --production` and there's a large list of dependencies that aren't listed in `build/package/{LICENSE,NOTICE,NONOTICE}` in this PR. Maybe something is still wrong with the command I'm running or my environment? Or maybe these are excluded for a reason?
```
@cspotcode/source-map-support@0.8.1
@grpc/proto-loader@0.7.4
@jridgewell/resolve-uri@3.1.0
@jridgewell/sourcemap-codec@1.4.14
@jridgewell/trace-mapping@0.3.9
@protobufjs/aspromise@1.1.2
@protobufjs/base64@1.1.2
@protobufjs/codegen@2.0.4
@protobufjs/eventemitter@1.1.0
@protobufjs/fetch@1.1.0
@protobufjs/float@1.0.2
@protobufjs/inquire@1.1.0
@protobufjs/path@1.1.2
@protobufjs/pool@1.1.0
@protobufjs/utf8@1.1.0
@tsconfig/node10@1.0.9
@tsconfig/node12@1.0.11
@tsconfig/node14@1.0.3
@tsconfig/node16@1.0.3
@types/long@4.0.2
acorn-walk@8.2.0
acorn@8.8.2
ansi-regex@5.0.1
ansi-styles@4.3.0
arg@4.1.3
buffers@0.1.1
chainsaw@0.1.0
cliui@7.0.4
color-convert@2.0.1
color-name@1.1.4
create-require@1.1.1
diff@4.0.2
emoji-regex@8.0.0
escalade@3.1.1
get-caller-file@2.0.5
has-flag@4.0.0
is-fullwidth-code-point@3.0.0
lodash.camelcase@4.3.0
long@4.0.0
make-error@1.3.6
minimist@1.2.7
ms@2.1.2
omega-edit@0.9.34
os-paths@7.3.0
protobufjs@7.2.0
require-directory@2.1.1
string-width@4.2.3
strip-ansi@6.0.1
supports-color@7.2.0
traverse@0.3.9
v8-compile-cache-lib@3.0.1
wrap-ansi@7.0.0
y18n@5.0.8
yargs-parser@20.2.9
yargs@16.2.0
yn@3.1.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1108806804
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
Yeah looking into more maybe these do get included into the packages based on the differences between `yarn list --prod` and `yarn list --dev`. I will get these added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1108837054
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
@stevedlawrence I believe this should be good now. `omega-edit` was listed in the `build/package/NOTICE` file. Items:
```bash
@grpc/proto-loader
long
```
Were added to the `build/package/NONOTICE` file. The rest got added to `build/package/LICENSE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#issuecomment-1421297526
@stevedlawrence I assigned you to this one as because this mostly dealt with items you mentioned in your vote for 1.2.0. So would like to get your input on the updates, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1101832451
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
Yeah you are right. So I was doing `yarn list --production` but thought only the highlighted items were production packages. I will get this fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1101846736
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
@stevedlawrence Yeah so what I did was use `yarn list --production` and only grabbed the main dependencies, and their transitive dependencies, that were listed in the `package.json` file's `dependencies` section. Any main/transitive deps listed in the `package.json` file's `devDependencies` section were ignored. If this is what is wanted I would say the current listed items would be correct.
As I ran `yarn licensees list --production` I am seeing items listed in the `package.json` as `devDependencies` being listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1101846736
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
Yeah so what I did was use `yarn list --production` and only grabbed the main dependencies, and their transitive dependencies, that were listed in the `package.json` file's `dependencies` section. Any main/transitive deps listed in the `package.json` file's `devDependencies` section were ignored. If this is what is wanted I would say the current listed items would be correct.
As I ran `yarn licensees list --production` I am seeing items listed in the `package.json` as `devDependencies` being listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1101793823
##########
build/package/LICENSE:
##########
@@ -224,24 +224,6 @@ conditions of the following licenses.
This project is free software released under the MIT license:
http://www.opensource.org/licenses/mit-license.php
-- 'buffers' in extension/dist/ext/extension.js
Review Comment:
When I run `yarn licenses list --production`, I still see many of these licenses that have been removed. I assume I'm doing something wrong. Is there a different way to generate the right list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#discussion_r1113082504
##########
build/package/LICENSE:
##########
@@ -319,69 +236,108 @@ conditions of the following licenses.
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
-- 'os-paths' extension/dist/ext/extension.js
- This product bundles 'os-paths' from the above files.
- These files are available under the MIT License:
-
+- 'ansi-regex' in extension/dist/ext/extension.js
+- 'ansi-styles' in extension/dist/ext/extension.js
+- 'is-fullwidth-code-point' in extension/dist/ext/extension.js
+- 'string-width' in extension/dist/ext/extension.js
+- 'wrap-ansi' in extension/dist/ext/extension.js
+ This product bundles 'ansi-regex', 'ansi-styles', 'is-fullwidth-code-point', 'string-width' and 'wrap-ansi' from the above files.
+ These packages are available under the MIT License:
MIT License
- Copyright (c) Roy Ivy III <ri...@gmail.com>
- Copyright (c) Sindre Sorhus <si...@gmail.com> (sindresorhus.com)
+ Copyright (c) Sindre Sorhus <si...@gmail.com> (https://sindresorhus.com)
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+- 'arg' in extension/dist/ext/extension.js
+ This product bundles 'arg' from the above files.
Review Comment:
It's not obvious in this diff, but these files mix tabs and spaces in some places. It might be worth converting them to spaces just so we're consistent.
##########
build/package/LICENSE:
##########
@@ -924,75 +844,50 @@ conditions of the following licenses.
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- ====
-
- Copyright and related rights for sample code are waived via CC0. Sample
- code is defined as all source code displayed within the prose of the
- documentation.
-
- CC0: http://creativecommons.org/publicdomain/zero/1.0/
-
- ====
-
- Files located in the node_modules and vendor directories are externally
- maintained libraries used by this software which have their own
- licenses; we recommend you read them, as their terms may differ from the
- terms above.
-
-- 'prettier' in extension/dist/ext/extension.js
- This product bundles 'prettier' from the above files.
- This package is available under the MIT License:
- Copyright © James Long and contributors
-
- Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
- The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+- 'v8-compile-cache-lib' in extension/dist/ext/extension.js
+ This product bundles 'v8-compile-cache-lib' from the above files.
+ This package is available under the MIT LICENSE:
-- 'require-directory' in extension/dist/ext/extension.js
- This product bundles 'require-directory' from the above files.
- This package is available under the MIT License:
The MIT License (MIT)
+
+ Copyright (c) 2019 Andres Suarez
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to deal
+ in the Software without restriction, including without limitation the rights
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
- Copyright (c) 2011 Troy Goode <tr...@gmail.com>
-
- Permission is hereby granted, free of charge, to any person obtaining a
- copy of this software and associated documentation files (the
- "Software"), to deal in the Software without restriction, including
- without limitation the rights to use, copy, modify, merge, publish,
- distribute, sublicense, and/or sell copies of the Software, and to
- permit persons to whom the Software is furnished to do so, subject to
- the following conditions:
-
- The above copyright notice and this permission notice shall be included
- in all copies or substantial portions of the Software.
-
- THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
- OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
- CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
- TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
- SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-- 'yargs' in extension/dist/ext/extension.js
- This product bundles 'yargs' from the above files.
- This package is available under the MIT License:
- MIT License
-
- Copyright 2010 James Halliday (mail@substack.net); Modified work Copyright 2014 Contributors (ben@npmjs.com)
+- 'yargs-unparser' in extension/dist/ext/extension.js
Review Comment:
I don't see `yargs-unparser` in the list of dependencies. I only see `yargs-parser` (listed above) and `yargs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #448: Update LICENSE, NONOTICE and remove NOLICENSE
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #448:
URL: https://github.com/apache/daffodil-vscode/pull/448#issuecomment-1438743445
@stevedlawrence The `yargs-unparser` must have slipped pasted me. I got that remove then fixed the inconsistency with tabs and spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org