You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/01/09 17:15:34 UTC
[GitHub] [sling-org-apache-sling-commons-metrics] joerghoh opened a new pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
joerghoh opened a new pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1
…d support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008338987
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] removed a comment on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008338987
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] joerghoh commented on a change in pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r781046091
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with {@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
ok, I understand.
Extending the ```Metric``` interface is also not really necessary from an API point of view, it is only needed at the implementation level. I will change the implementation so the existing Gauge interface (as a ConsumerType) will stay as it currently is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] removed a comment on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008343128
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008343128
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] cziegeler commented on a change in pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r780910195
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with {@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
I fear we need to create a new interface - Gauge is right now a ConsumerType - this new gauge should be a ProviderType. As Metric is a ProviderType Gauge can't extend Metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] removed a comment on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008345054
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008776807
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [53.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] joerghoh merged pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
joerghoh merged pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] cziegeler commented on a change in pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r781031554
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with {@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
First of all, it can't be both - its either a consumer type to be implemented by a consumer of that API, or it is a provider type - provided by the implementation. (Implementations can of course also implement consumer types).
Second, by changing (extending) the existing Gauge interface, all current implementations will be broken as they most likely will not implement Metric.
With Gauge now extending a ProviderType a guess that breaking change is hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] joerghoh commented on a change in pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r781029053
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with {@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
So is the problem the fact that the "new Gauge" should be a ProviderType and this one is a ConsumerType? Isn't it possible to use this interface for both cases?
Or is the problem rather that this ConsumerType extends a Providertype?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-commons-metrics] sonarcloud[bot] commented on pull request #1: SLING-10967 add support to register Gauges directly without whiteboar…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#issuecomment-1008345054
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list) [62.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-metrics&pullRequest=1&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org