You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/08 14:13:48 UTC

[GitHub] [cordova-android] breautek commented on a change in pull request #859: Removed unnecessary project name restriction

breautek commented on a change in pull request #859: Removed unnecessary project name restriction
URL: https://github.com/apache/cordova-android/pull/859#discussion_r344191605
 
 

 ##########
 File path: bin/lib/create.js
 ##########
 @@ -225,11 +225,6 @@ function validateProjectName (project_name) {
         return Q.reject(new CordovaError(msg + 'Project name cannot be CordovaActivity'));
 
 Review comment:
   You're probably right there. I'll do some testing with that removed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org