svn commit: r185062 - /directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java

[el...@apache.org]

Author: elecharny
Date: Mon Jun  6 15:23:14 2005
New Revision: 185062

URL: http://svn.apache.org/viewcvs?rev=185062&view=rev
Log:
Added a method that returns a SearchResultPOJO directly, avoiding a cast.

Modified:
    directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java

Modified: directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java
URL: http://svn.apache.org/viewcvs/directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java?rev=185062&r1=185061&r2=185062&view=diff
==============================================================================
--- directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java (original)
+++ directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java Mon Jun  6 15:23:14 2005
@@ -127,6 +127,17 @@
     }
 
     /**
+     * Get a SearchRequest POJO, assuming that the caller knows that
+     * it is the LdapMessage exact type.
+     *
+     * @return Returns the SearchRequest POJO.
+     */
+    public SearchRequestPOJO getSearchRequest()
+    {
+        return (SearchRequestPOJO)protocolOp;
+    }
+
+    /**
      * Set the ProtocolOP
      *
      * @param protocolOp The protocolOp to set.

Re: svn commit: r185062 - /directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java

[Emmanuel Lecharny <el...@apache.org>]

> Why put POJO into the name ... this is naturally inferred no?  

Well, there is no technical reasons. This may be the consequence of a
chat we had with Alan, where we discussed about objects being created by
an hypothetic ASN.1 compiler, and we were talking of POJOs. So it's
temporary.

> I know 
> its a pojo because you're not using Avalon or something and if you did 
> then you can name those components.  I usually find I think in an 
> inverted way.... otherwise too many things will have POJO at the end of em.

I agree with you. Let's stop this POJO infection :) A java class is a
POJO, no?

> 
> My 2 cents ... don't let me slow your most excellent progress.

It won't ! And refactoring cost only 2 cents, so changing all the POJOs
to something simpler will be done.

Re: svn commit: r185062 - /directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java

[Alex Karasulu <ao...@bellsouth.net>]

elecharny@apache.org wrote:

>Author: elecharny
>  
>
<snip/>

>Modified:
>    directory/sandbox/trunk/asn1-new-codec/src/java/org/apache/asn1/ldap/pojo/LdapMessagePOJO.java
>

Why put POJO into the name ... this is naturally inferred no?  I know 
its a pojo because you're not using Avalon or something and if you did 
then you can name those components.  I usually find I think in an 
inverted way.... otherwise too many things will have POJO at the end of em.

My 2 cents ... don't let me slow your most excellent progress.

Cheers,
Alex