You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/08/13 09:41:14 UTC
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 7:41 a.m.)
Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
Bugs: CLOUDSTACK-1800
Repository: cloudstack-git
Description
-------
CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
Diffs (updated)
-----
test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
Diff: https://reviews.apache.org/r/12545/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review25062
-----------------------------------------------------------
Review 12545 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #120 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/120/
- Jenkins Cloudstack.org
On Aug. 13, 2013, 7:41 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 7:41 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review25616
-----------------------------------------------------------
Hi Girish Shilamkar,
Apologies for late review.
Some changes needs to be taken care of.
1) I think we do not have service like "SSHKey" to get the sshkey enabled template. We need to create a vm, put the ssh/password scripts accordingly in the VM, create template from that VM and then use this template for our tests. You can refer to marvin test in test_vm_passwdenabled.py
2) We have 10 tests in this file and each test tries to create separate account, networks, router vms and guest vms. Could you please try clubbing the resources in the tests that use common resources.
- Harikrishna Patnala
On Aug. 13, 2013, 7:41 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 7:41 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review26131
-----------------------------------------------------------
Ship it!
Ship It!
- Harikrishna Patnala
On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review26202
-----------------------------------------------------------
Commit dd4b1cbf449b63cd2b34197c7c9b19ec1cc4822e in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=dd4b1cb ]
CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
Reviewed-By: Harikrishna Patnala <ha...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On Sept. 18, 2013, 4:04 a.m., Prasanna Santhanam wrote:
> > master, 4.2-forward
In this code, piece of code executing in a loop this need be fixed
578 while True:
579 vms = VirtualMachine.list(
580 self.apiclient,
581 account=self.account.name,
582 domainid=self.account.domainid,
583 listall=True
584 )
585 if vms[0].state == "Running":
586 break
587 self.debug("Vm not in Running state sleep 60s")
588 time.sleep(60)
defect https://issues.apache.org/jira/browse/CLOUDSTACK-4766 created
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review26204
-----------------------------------------------------------
On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review26204
-----------------------------------------------------------
Ship it!
master, 4.2-forward
- Prasanna Santhanam
On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/#review26203
-----------------------------------------------------------
Commit 8cc37c24705dfcc2ddb973673522fa39bf246ef5 in branch refs/heads/4.2-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8cc37c2 ]
CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
Reviewed-By: Harikrishna Patnala <ha...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit dd4b1cbf449b63cd2b34197c7c9b19ec1cc4822e)
- ASF Subversion and Git Services
On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12545/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-1800
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12545/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset
sshkey to access VM
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12545/
-----------------------------------------------------------
(Updated Sept. 14, 2013, 7:46 a.m.)
Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam.
Changes
-------
Updated as per the review.
Bugs: CLOUDSTACK-1800
Repository: cloudstack-git
Description
-------
CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
Diffs (updated)
-----
test/integration/component/test_reset_ssh_keypair.py PRE-CREATION
Diff: https://reviews.apache.org/r/12545/diff/
Testing
-------
Thanks,
Girish Shilamkar