You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/07 06:55:35 UTC

[GitHub] [pinot] KKcorps commented on pull request #8602: Change shading prefix so as to minimize conflicts with other libaries

KKcorps commented on PR #8602:
URL: https://github.com/apache/pinot/pull/8602#issuecomment-1148269077

   @jackjlli IMO, the only place it will cause an issue is while importing the Kafka classes. Anywhere else, it should work fine the way it is. In our code at least we don't import anything with `shaded.` prefix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org