[GitHub] [hudi] codope commented on a change in pull request #3240: [HUDI-2144]Bug-Fix:Offline clustering(HoodieClusteringJob) will cause insert action losing data

[GitBox <gi...@apache.org>]

codope commented on a change in pull request #3240:
URL: https://github.com/apache/hudi/pull/3240#discussion_r667097064



##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java
##########
@@ -146,7 +146,7 @@ private int addUpdateBucket(String partitionPath, String fileIdHint) {
    * @return smallFiles not in clustering
    */
   private List<SmallFile> filterSmallFilesInClustering(final Set<String> pendingClusteringFileGroupsId, final List<SmallFile> smallFiles) {
-    if (this.config.isClusteringEnabled()) {
+    if (this.config.isClusteringEnabled() || !pendingClusteringFileGroupsId.isEmpty()) {

Review comment:
       If the clustering is not enabled, can the `pendingClusteringFileGroupsId ` set be non-empty? Would be great if we can add a test to replicate the scenario.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org