You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/22 12:25:27 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #338: fsutils/mkfatfs: use DMA memory for mkfatfs when needed

patacongo commented on a change in pull request #338:
URL: https://github.com/apache/incubator-nuttx-apps/pull/338#discussion_r458751928



##########
File path: fsutils/mkfatfs/mkfatfs.c
##########
@@ -337,7 +338,11 @@ int mkfatfs(FAR const char *pathname, FAR struct fat_format_s *fmt)
 
   /* Allocate a buffer that will be working sector memory */
 
+#ifdef CONFIG_FAT_DMAMEMORY
+  var.fv_sect = (FAR uint8_t *)fat_dma_alloc(var.fv_sectorsize);
+#else

Review comment:
       Sorry this cannot be merged  Applications ares not permitted to call internal to call internal operating system interfaces.  That violates the porttable POSIX interface and will break all PROTECTED and KERNAL biulds that use mkfatfs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org