You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2009/03/01 16:17:13 UTC
[jira] Created: (DIRSTUDIO-468) The LDIF parser does not correctly
parse changes
The LDIF parser does not correctly parse changes
------------------------------------------------
Key: DIRSTUDIO-468
URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
Project: Directory Studio
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Emmanuel Lecharny
Priority: Minor
Fix For: 1.4.0
Trying to parse such a LDIF :
# principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
# timestamp: 1235905921781
# revision: 1235905920724
dn: 2.5.4.3=the person,2.5.4.11=system
changeType: modify
add: objectclass
objectclass: organizationalPerson
objectclass: inetOrgPerson
-
you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677814#action_12677814 ]
Stefan Seelmann commented on DIRSTUDIO-468:
-------------------------------------------
Or a google-like warning "Did you mean: changetype?" as yellow marker.
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677823#action_12677823 ]
Emmanuel Lecharny commented on DIRSTUDIO-468:
---------------------------------------------
Rearding the order, we may be less strict.
The empty modification should be accepted. The server won't do anything. This is a direct consequence of what RFC 4511 says about Modify operation :
"A replace with no value will delete the entire attribute if it exists, and it is ignored if the attribute does not exist."
When the server received a ModifyRequest with a replace without values for a non existing attribute, the attribute is removed from the request. If we don't have any remaining attribute, the server does nothing.
A very special corner case, IMO...
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677818#action_12677818 ]
Stefan Seelmann commented on DIRSTUDIO-468:
-------------------------------------------
Yes, according to RFC 2849. Maybe too strict. Should we allow any order?
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677811#action_12677811 ]
Stefan Seelmann commented on DIRSTUDIO-468:
-------------------------------------------
The problem is that the 'T' in changetype is uppercase. This causes that the LDIF isn't recognized as change record. Should the keyword (dn, changtype, modify, add, delete, moddn, etc) be case insensitive?
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSTUDIO-468) The LDIF parser does not correctly
parse changes
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seelmann resolved DIRSTUDIO-468.
---------------------------------------
Resolution: Fixed
Assignee: Stefan Seelmann
All three issues are fixed:
http://svn.apache.org/viewvc?rev=749785&view=rev
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Assignee: Stefan Seelmann
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-468) The LDIF parser does not correctly
parse changes
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-468:
---------------------------------------------
Component/s: studio-ldifeditor
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-ldifeditor
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Assignee: Stefan Seelmann
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677817#action_12677817 ]
Emmanuel Lecharny commented on DIRSTUDIO-468:
---------------------------------------------
I also have a pb with such an entry :
# principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
# timestamp: 1235922630304
# revision: 1235922623664
dn: 2.5.4.3=tori amos,2.5.4.11=system
changetype: modify
I don't know what would this change mean, but it's legal from the LDIF grammar POV.
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677819#action_12677819 ]
Stefan Seelmann commented on DIRSTUDIO-468:
-------------------------------------------
Is it possible to send an empty modification to the server? What would the server do? Just update the modifyTimestamp, like a touch on unix?
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677816#action_12677816 ]
Emmanuel Lecharny commented on DIRSTUDIO-468:
---------------------------------------------
We also have problem with the moddn operation : it's expecting the newRDN, deleteOldRdn and newSuperior in this order.
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-468) The LDIF parser does not
correctly parse changes
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677813#action_12677813 ]
Emmanuel Lecharny commented on DIRSTUDIO-468:
---------------------------------------------
Correct ! Then we have two ways to deal with the problem :
- accept upper cases for chageType or other constants
- or generate an error on the right position
I would pick option #1
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSTUDIO-468) The LDIF parser does not correctly
parse changes
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRSTUDIO-468.
---------------------------------------
> The LDIF parser does not correctly parse changes
> ------------------------------------------------
>
> Key: DIRSTUDIO-468
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-468
> Project: Directory Studio
> Issue Type: Bug
> Components: studio-ldifeditor
> Affects Versions: 1.3.0
> Reporter: Emmanuel Lecharny
> Assignee: Stefan Seelmann
> Priority: Minor
> Fix For: 1.4.0
>
>
> Trying to parse such a LDIF :
> # principal: 0.9.2342.19200300.100.1.1=admin,2.5.4.11=system
> # timestamp: 1235905921781
> # revision: 1235905920724
> dn: 2.5.4.3=the person,2.5.4.11=system
> changeType: modify
> add: objectclass
> objectclass: organizationalPerson
> objectclass: inetOrgPerson
> -
> you get an error message, as the last '-' is considered as a wrong token
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.