You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/25 12:09:31 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #8945: Attempt to use first NonLoopbackAddress when registering nacos instance.

wu-sheng commented on PR #8945:
URL: https://github.com/apache/skywalking/pull/8945#issuecomment-1108488452

   Ww discussed about this before, 2 things
   
   1. Use this setup means you have known what to do, and what does this setup mean
   2. Use the first IP address doesn't change the fact it still could be wrong. A little approvement, but not much
   
   And from the code perspective, if this is going to be accepted, we have to change all cluster manager implementations, besides k8s as it is automatically working. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org