[jira] [Commented] (HBASE-23234) Checkstyle and formatter disagree on indentation

["Nick Dimiduk (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976774#comment-16976774 ] 

Nick Dimiduk commented on HBASE-23234:
--------------------------------------

Looks like there's now a lingua franca for editor code formatting configs, [Editor Config|https://editorconfig.org/]. IntelliJ supports defining a configuration from a checkstyle config, and will export its configuration in this editor config format.

> Checkstyle and formatter disagree on indentation
> ------------------------------------------------
>
>                 Key: HBASE-23234
>                 URL: https://issues.apache.org/jira/browse/HBASE-23234
>             Project: HBase
>          Issue Type: Task
>          Components: build, tooling
>            Reporter: Nick Dimiduk
>            Priority: Major
>
> I don't have an exhaustive analysis of the issue, but there's at least one case where check style plugin configuration disagrees with our settings in {{dev-support/hbase_eclipse_formatter.xml}}.
> Formatter settings produce this code chunk
> {noformat}
>       uncaughtExceptionHandler =
>           (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}
> but check style wants
> {noformat}
>       uncaughtExceptionHandler =
>         (t, e) -> abort("Uncaught exception in executorService thread " + t.getName(), e);
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)