[GitHub] [tinkerpop] spmallette opened a new pull request #1444: TINKERPOP-2534 Switched test/distribution logging to logback

[GitBox <gi...@apache.org>]

spmallette opened a new pull request #1444:
URL: https://github.com/apache/tinkerpop/pull/1444


   https://issues.apache.org/jira/browse/TINKERPOP-2534
   
   There is a CVE with log4j 1.2 which EOL'd 5 years ago. We haven't really focused on changing this earlier because log4j is an optional dependency and can be swapped out by the user to their preferred logging provider given that we use slf4j. That said, it's better that we simply not include it in our distributions and docker packaging would work better out of the box without the CVE struck log4j in the mix. logback is dual licensed, but given that one of those licenses is under EPL we can make use of it - see https://issues.apache.org/jira/browse/LEGAL-63 for futher details if needed.
   
   All tests pass with `docker/build.sh -t -n -i`. Logging tested for server/console distributions and their respective docker containers. Test logging seems correct as well since Travis passed.
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette merged pull request #1444: TINKERPOP-2534 Switched test/distribution logging to logback

[GitBox <gi...@apache.org>]

spmallette merged pull request #1444:
URL: https://github.com/apache/tinkerpop/pull/1444


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org