You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/28 01:56:06 UTC

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #15733: [fix][admin] Unwrap the completion exception on schemas admin API

Demogorgon314 commented on code in PR #15733:
URL: https://github.com/apache/pulsar/pull/15733#discussion_r884051017


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiSchemaTest.java:
##########
@@ -247,6 +249,25 @@ public void createKeyValueSchema(ApiVersion version) throws Exception {
         assertEquals(keyValueSchema.getSchemaInfo(), schemaInfo);
     }
 
+
+    @Test(dataProvider = "version")
+    public void testInvalidSchemaDataException(ApiVersion version) {
+        String namespace = format("%s%s%s", "schematest", (ApiVersion.V1.equals(version) ? "/" + cluster + "/" : "/"),
+                "test");
+        String topicName = "persistent://"+ namespace + "/test-invalid-schema-data-exception";
+        SchemaInfo schemaInfo = SchemaInfo.builder()
+                .schema(new byte[0])
+                .type(SchemaType.AVRO)
+                .name("test")
+                .build();
+        try {
+            admin.schemas().createSchema(topicName, schemaInfo);

Review Comment:
   Oh, the PR gets merged. I can fix it in other PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org