[GitHub] [spark] HyukjinKwon commented on a change in pull request #24065: [SPARK-27130][BUILD] Automatically select profile when executing sbt-checkstyle

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24065: [SPARK-27130][BUILD] Automatically select profile when executing sbt-checkstyle
URL: https://github.com/apache/spark/pull/24065#discussion_r264608902
 
 

 ##########
 File path: dev/sbt-checkstyle
 ##########
 @@ -17,17 +17,13 @@
 # limitations under the License.
 #
 
+build_profiles=$1
+echo "Checking Spark style using SBT with these arguments: ${build_profiles}"
+
 # NOTE: echo "q" is needed because SBT prompts the user for input on encountering a build file
 # with failure (either resolution or compilation); the "q" makes SBT quit.
 ERRORS=$(echo -e "q\n" \
-    | build/sbt \
-        -Pkinesis-asl \
-        -Pmesos \
-        -Pkubernetes \
-        -Pyarn \
-        -Phive \
-        -Phive-thriftserver \
-        checkstyle test:checkstyle \
 
 Review comment:
   @wangyum, can we keep this existing profiles if arguments are not given? This script can be manually ran as well. This is intentionally matched with `lint-java`'s.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org