You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/28 14:21:29 UTC

[GitHub] [kafka] divijvaidya opened a new pull request, #12911: KAFKA-14418: Do not allow modifying partition of internal topics from admin commands

divijvaidya opened a new pull request, #12911:
URL: https://github.com/apache/kafka/pull/12911

   Today a user can change the number of partitions of `__consumer_offsets` topic by changing the configuration value for `offsets.topic.num.partitions` or manually by using `./bin/kafka-topics.sh`. For example, the following command changes the number of partitions to 60 for `__consumer_offsets` topic.
   `./bin/kafka-topics.sh --topic __consumer_offsets --alter --partitions 60 --bootstrap-server=localhost:9092`
   
   Changing offsets of this reserved topic leads to problems with consumer group detection of coordinator unless you restart all brokers.  Thus, there is a high probability that is this operations is not done right (i.e. if it is not followed by a cluster restart), users may shoot themselves in the foot. Example scenario: https://stackoverflow.com/questions/73944561/kafka-consumer-group-coordinator-inconsistent.
   
   Same goes for [transaction.state.log.num.partitions](https://kafka.apache.org/documentation/#brokerconfigs_transaction.state.log.num.partitions)
   
   ## Change
   This is one of multiple changes to address this problem. In the current PR we disallow modification of number of partitions via the admin command so that the modification is only allowed via the provided configuration `transaction.state.log.num.partitions` and `offsets.topic.num.partitions`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #12911: KAFKA-14418: Do not allow modifying partition of internal topics from admin commands

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #12911:
URL: https://github.com/apache/kafka/pull/12911#issuecomment-1506744623

   For completeness - this is the KIP as a follow up for this request https://cwiki.apache.org/confluence/display/KAFKA/KIP-895%3A+Dynamically+refresh+partition+count+of+__consumer_offsets 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya closed pull request #12911: KAFKA-14418: Do not allow modifying partition of internal topics from admin commands

Posted by GitBox <gi...@apache.org>.
divijvaidya closed pull request #12911: KAFKA-14418: Do not allow modifying partition of internal topics from admin commands
URL: https://github.com/apache/kafka/pull/12911


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #12911: KAFKA-14418: Do not allow modifying partition of internal topics from admin commands

Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12911:
URL: https://github.com/apache/kafka/pull/12911#issuecomment-1340820090

   Discarding this PR. We will start a KIP for a better way to handle modifications of number of partitions for `__consumer_offsets`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org