You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "FelixYBW (via GitHub)" <gi...@apache.org> on 2026/07/18 20:32:35 UTC

[PR] [VL] Fix run-scala-test.sh and add skills for rebase [gluten]

FelixYBW opened a new pull request, #12558:
URL: https://github.com/apache/gluten/pull/12558

   We are handling velox daily rebase. We need to use AI to accelerate the process


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Fix run-scala-test.sh and add skills for rebase [gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12558: [VL] Fix run-scala-test.sh and add skills for rebase
URL: https://github.com/apache/gluten/pull/12558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Fix run-scala-test.sh and add skills for rebase [gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12558:
URL: https://github.com/apache/gluten/pull/12558#issuecomment-5650012304

   This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Fix run-scala-test.sh and add skills for rebase [gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12558:
URL: https://github.com/apache/gluten/pull/12558#issuecomment-5503073602

   This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [VL] Fix run-scala-test.sh and add skills for rebase [gluten]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12558:
URL: https://github.com/apache/gluten/pull/12558#discussion_r3609147761


##########
dev/run-scala-test.sh:
##########
@@ -611,6 +611,40 @@ if [[ -d "$MODULE_CLASSES" ]]; then
   RESOLVED_CLASSPATH="${MODULE_CLASSES}:${RESOLVED_CLASSPATH}"
 fi
 
+# For each requested suite, check if its .class file is missing from the
+# current classpath. If so, scan all known module test-class directories to
+# find the one that owns the class and prepend it.  This handles suites that
+# live in a dependency module (e.g. backends-velox) when the driver module
+# (e.g. gluten-ut/spark35) is passed via -pl.
+for _suite in "${SUITES[@]}"; do
+  _class_rel="${_suite//.//}.class"
+  _found_in_cp=false
+  IFS=':' read -ra _CP_CHECK <<< "$RESOLVED_CLASSPATH"
+  for _cp_entry in "${_CP_CHECK[@]}"; do
+    if [[ -f "${_cp_entry}/${_class_rel}" ]]; then
+      _found_in_cp=true
+      break
+    fi
+  done
+
+  if [[ "$_found_in_cp" == "false" ]]; then
+    log_warn "Suite ${_suite} not found in current classpath — scanning module test-class dirs..."
+    for _artifact in "${!MODULE_MAP[@]}"; do
+      _tc_dir=$(get_target_dir "$_artifact" "$SCALA_VERSION" "test-classes")
+      if [[ -f "${_tc_dir}/${_class_rel}" ]]; then
+        log_info "  Found in ${_tc_dir} — prepending to classpath"
+        RESOLVED_CLASSPATH="${_tc_dir}:${RESOLVED_CLASSPATH}"
+        # Also prepend the corresponding classes/ dir so companion objects load
+        _cls_dir=$(get_target_dir "$_artifact" "$SCALA_VERSION" "classes")
+        if [[ -d "$_cls_dir" && "$RESOLVED_CLASSPATH" != *"${_cls_dir}"* ]]; then

Review Comment:
   The classpath containment check for `_cls_dir` uses substring matching (`!= *"${_cls_dir}"*`), which can yield false positives when one entry is a prefix of another (e.g., `/path/mod` vs `/path/mod-extra`). That can incorrectly skip prepending the needed classes dir and lead to `ClassNotFoundException` at runtime.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org