You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2019/09/27 22:48:09 UTC
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14318
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Remove hard-coded localhost from impala_test_suite.py
Hard-coding "localhost" into the test framework breaks being able to
run the tests against deployed/non-local clusters.
Tested by running tests against a deployed cluster from a local checkout
of the repo, and confirming that we can connect to the remote debug page.
Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
---
M tests/common/impala_test_suite.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/14318/1
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5041/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 02:40:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5077/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 08:27:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5020/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Sep 2019 00:02:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py@128
PS1, Line 128: impalad_hostname = pytest.config.option.impalad.split(',')[0].split(':')[0]
IMPALAD_HOSTNAME?
Also, maybe better to combine this with the stuff above to reduce duplication, i.e. define IMPALAD_HOSTNAME immediately after IMPALAD above, and then use it when constructing IMPALAD_HS2_HOST_PORT, etc.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 22:52:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 15:52:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> (1 comment)
Thanons
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/14318/1/tests/common/impala_test_suite.py@128
PS1, Line 128: VARZ_URL = 'http://{0}:25000/varz?json'.format(IMPALAD_HOSTNAME)
> IMPALAD_HOSTNAME?
Done
Thanks Thomas -- good point. I wasn't looking above.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 23:15:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 12:42:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5041/
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 06:57:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5020/
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Sep 2019 04:19:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4672/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 23:55:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5080/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 15:53:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14318
to look at the new patch set (#2).
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Remove hard-coded localhost from impala_test_suite.py
Hard-coding "localhost" into the test framework breaks being able to
run the tests against deployed/non-local clusters.
Tested by running tests against a deployed cluster from a local checkout
of the repo, and confirming that we can connect to the remote debug page.
Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
---
M tests/common/impala_test_suite.py
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/14318/2
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Remove hard-coded localhost from impala_test_suite.py
Hard-coding "localhost" into the test framework breaks being able to
run the tests against deployed/non-local clusters.
Tested by running tests against a deployed cluster from a local checkout
of the repo, and confirming that we can connect to the remote debug page.
Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Reviewed-on: http://gerrit.cloudera.org:8080/14318
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: David Knupp <dk...@cloudera.com>
---
M tests/common/impala_test_suite.py
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
David Knupp: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 23:45:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 02:40:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove hard-coded localhost from impala test suite.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14318 )
Change subject: Remove hard-coded localhost from impala_test_suite.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c52d94d9876661faada42d6570ef5005960e74d
Gerrit-Change-Number: 14318
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 23:27:37 +0000
Gerrit-HasComments: No