You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jackylee-ch (via GitHub)" <gi...@apache.org> on 2026/10/04 00:36:43 UTC
[PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
jackylee-ch opened a new pull request, #10366:
URL: https://github.com/apache/paimon/pull/10366
### Purpose
`CoreOptions.varTypeSize()` returned `zorder.var-length-contribution` unchecked. It
sizes the `new byte[]` z-order buffers in `ZIndexer` and `SparkZOrderUDF`, so a negative
value crashes zorder clustering / sort-compact over a `CHAR` / `VARCHAR` / `BINARY` /
`VARBINARY` column with `NegativeArraySizeException`, and `0` silently drops the
variable-length column from the z-order curve.
This validates the option is positive in the getter — the single accessor feeding the
core, Flink and Spark zorder sorters — mirroring the other positive-int option guards in
`CoreOptions`. The default is `8`, so valid configurations are unaffected.
### Tests
`CoreOptionsTest#testVarTypeSizeRejectsNonPositive` asserts `0` and `-1` throw a clear
`IllegalArgumentException`.
### API and Format
No change.
### Documentation
No change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #10366: [core] Reject a non-positive zorder.var-length-contribution
URL: https://github.com/apache/paimon/pull/10366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on PR #10366:
URL: https://github.com/apache/paimon/pull/10366#issuecomment-5994933765
@JingsongLi Thanks for the reminder. Going forward, I’ll focus my contributions on a few specific areas and stay more deeply involved in the development work.
Also, thanks for reviewing my previous PRs. I really appreciate your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #10366:
URL: https://github.com/apache/paimon/pull/10366#issuecomment-5994749083
Your PRs for simple validations are honestly exhausting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #10366:
URL: https://github.com/apache/paimon/pull/10366#issuecomment-5994862751
@jackylee-ch Based on the quality of your previous PRs, it appears that your subsequent submissions are likely to be of low value. If this trend continues—especially if you use AI to generate a large volume of PRs—I will simply skip them. Please ensure you conduct thorough manual reviews yourself; rely on human oversight rather than just AI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Reject a non-positive zorder.var-length-contribution [paimon]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch closed pull request #10366: [core] Reject a non-positive zorder.var-length-contribution
URL: https://github.com/apache/paimon/pull/10366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org