You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/18 11:46:08 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request #746: Move assert_batches_eq! macros to test_utils.rs

alamb opened a new pull request #746:
URL: https://github.com/apache/arrow-datafusion/pull/746


   # Which issue does this PR close?
   
   Closes #745, re https://github.com/apache/arrow-datafusion/issues/743
   
    # Rationale for this change
   The `assert_batches_eq!` and `assert_batches_sorted_eq!` macros are used to write easier to maintain tests. However, the macros are in the `test` module that is only compiled for tests of the datafusion crate and are not, therefore, available to the "integration" style tests in `sql.rs`
   
   ```rust
   #[cfg(test)]
   pub mod test;
   ```
   
   I also find them so useful they are also in IOx in [test_utils.rs](https://github.com/influxdata/influxdb_iox/blob/411cf134e9087198f74fe78ccb3c62e16344bf2f/arrow_util/src/test_util.rs#L16) 
   
   # What changes are included in this PR?
   1. Move the he `assert_batches_eq!` and `assert_batches_sorted_eq!` macros to test_utils.rs
   2. port one test in sql.rs to demonstrate their use
   
   # Are there any user-facing changes?
   The  `assert_batches_eq!` and `assert_batches_sorted_eq!` macros are now part of the DataFusion public API
   
   Follow on work is tracked in #743
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #746: Move assert_batches_eq! macros to test_utils.rs

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #746:
URL: https://github.com/apache/arrow-datafusion/pull/746


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #746: Move assert_batches_eq! macros to test_utils.rs

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #746:
URL: https://github.com/apache/arrow-datafusion/pull/746


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #746: Move assert_batches_eq! macros to test_utils.rs

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #746:
URL: https://github.com/apache/arrow-datafusion/pull/746


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org