[jira] [Commented] (FELIX-5645) Embed-Transitive feature is no longer working

["Tuomas Kiviaho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142899#comment-16142899 ] 

Tuomas Kiviaho commented on FELIX-5645:
---------------------------------------

FELIX-3565 is probably the cause of what you are experiencing.

I'm using the following setup

{code:xml}
<Embed-Dependency>*;scope=compile|runtime|provided;type=!bundle</Embed-Dependency>
<Embed-Transitive>true</Embed-Transitive>
{code}

The scope and type can have tremendous impact on whether dependencies, transitive or not, are being included. With scope=provided the transitives aren't naturally being included in any scenario. In my case I don't want the {{<type>bundle</type>}} to be embedded at all nor it's transitive dependencies but at the same time I want to keep the {{<scope>compile</scope>}}. I have {{<type>jar</type>}} on those dependencies that I want to get embedded and now after the patch even the exclusion should as expected.

With this setup I've sometimes wanted to embed a certain 3rd party jar and wondered why it's not being embedded. A closer look always reveals that it's been created also with bundle plugin thus the packaging bundle must be overridden manually as {{<type>jar</type>}} and convention over configuration makes these cases kind of hard-to-spot.

I hope that the plugin isn't actually broken since the patch has been around for quite a long time.

> Embed-Transitive feature is no longer working
> ---------------------------------------------
>
>                 Key: FELIX-5645
>                 URL: https://issues.apache.org/jira/browse/FELIX-5645
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-3.3.0
>            Reporter: Martin Lichtin
>
> When trying to upgrade from version 2.4.0 to latest version 3.3.0,
> some bundles no longer are created as they 'should', with
> regards to embedding dependencies.
> Notably, transitive dependencies are no longer embedded.
> It looks like 
>             <Embed-Transitive>true</Embed-Transitive>
> is broken.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)