You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/02/23 12:48:08 UTC
[GitHub] [accumulo] dlmarion opened a new issue, #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
dlmarion opened a new issue, #3201:
URL: https://github.com/apache/accumulo/issues/3201
There is a Maven [build](https://github.com/apache/accumulo/blob/main/.github/workflows/maven.yaml#L73) as part of the GitHub Actions that uses ZooKeeper 3.5.10. Is this still needed for 3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #3201:
URL: https://github.com/apache/accumulo/issues/3201#issuecomment-1443649958
IMO we can remove this check for version 3.0 and beyond.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3201:
URL: https://github.com/apache/accumulo/issues/3201#issuecomment-1443739861
I made comments on the PR. I didn't mention log4j in my code review, but I don't think log4j is a good enough reason to stop testing these older versions that users could be using. It's very easy to patch log4j in production for those older versions. I'm sure there's lots of transitive dependency version bumps and changes, but since ZK and Hadoop are deployed by users independently from Accumulo (we don't bundle them) and its other dependencies, I think it still makes sense to test with it, so long as the tests are passing. At least, I'm not sure what harm is being done by the additional checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii closed issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
URL: https://github.com/apache/accumulo/issues/3201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ddanielr commented on issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on issue #3201:
URL: https://github.com/apache/accumulo/issues/3201#issuecomment-1442698042
The [original commit](https://github.com/apache/accumulo/pull/2516) for adding the zookeeper `3.5.x` option was due to the upgrade from `3.5` to zookeeper `3.7`
Before that upgrade, the test was just utilizing a previous version of hadoop.
`- {name: 'hadoop-compat', javaver: 11, args: 'package -DskipTests -Dhadoop.version=3.0.3'}`
vs
` - {name: 'compat', javaver: 11, args: 'package -DskipTests -Dhadoop.version=3.0.3 -Dzookeeper.version=3.5.10'}`
I'm surprised there is still a compatibility test for Hadoop `3.0.3` since the log4j issues weren't patched in the `3.0.x` line.
Is compatibility testing is still desired? If so, what should drive the version number choice?
Additional details:
- [HADOOP-18088](https://issues.apache.org/jira/browse/HADOOP-18088)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #3201: GitHub Actions Maven Build - Do we still need ZK 3.5.10 build?
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on issue #3201:
URL: https://github.com/apache/accumulo/issues/3201#issuecomment-1443994067
Superseded by patch to update to 3.6 in #3200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org